Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: remoting/protocol/webrtc_frame_scheduler.h

Issue 2405333002: Add remoting::protocol::NetworkStateObserver interface. (Closed)
Patch Set: address feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/webrtc_dummy_video_encoder.cc ('k') | remoting/protocol/webrtc_frame_scheduler_simple.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_frame_scheduler.h
diff --git a/remoting/protocol/webrtc_frame_scheduler.h b/remoting/protocol/webrtc_frame_scheduler.h
index 3a26b92b2974e72208b5b43b3da237e67821add5..3c15ff9f5eb1c7b9a208c4c6c637f41cc4f698d9 100644
--- a/remoting/protocol/webrtc_frame_scheduler.h
+++ b/remoting/protocol/webrtc_frame_scheduler.h
@@ -6,12 +6,16 @@
#define REMOTING_PROTOCOL_WEBRTC_FRAME_SCHEDULER_H_
#include "base/callback_forward.h"
+#include "base/memory/weak_ptr.h"
#include "remoting/codec/webrtc_video_encoder.h"
#include "third_party/webrtc/video_encoder.h"
namespace remoting {
namespace protocol {
+class VideoChannelStateObserver;
+class WebrtcDummyVideoEncoderFactory;
+
// An abstract interface for frame schedulers, which are responsible for
// scheduling when video frames are captured and for defining encoding
// parameters for each frame.
@@ -22,17 +26,12 @@ class WebrtcFrameScheduler {
// Starts the scheduler. |capture_callback| will be called whenever a new
// frame should be captured.
- virtual void Start(const base::Closure& capture_callback) = 0;
+ virtual void Start(WebrtcDummyVideoEncoderFactory* video_encoder_factory,
+ const base::Closure& capture_callback) = 0;
// Pause and resumes the scheduler.
virtual void Pause(bool pause) = 0;
- // Requests a key frame.
- virtual void SetKeyFrameRequest() = 0;
-
- // Sets network bitrate estimate.
- virtual void SetTargetBitrate(int bitrate_kbps) = 0;
-
// Called after |frame| has been captured to get encoding parameters for the
// frame. Returns false if the frame should be dropped (e.g. when there are
// no changed), true otherwise.
« no previous file with comments | « remoting/protocol/webrtc_dummy_video_encoder.cc ('k') | remoting/protocol/webrtc_frame_scheduler_simple.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698