Orphan ProcXfermode, with an eye towards removing it

Orphan ProcXfermode, with an eye towards removing it

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14238

[reed1, 2014-04-16 21:42:21]

btw -- shaves another 8 bytes off of the Flatten size.

Android problem?

[mtklein, 2014-04-16 21:50:13]

lgtm

https://codereview.chromium.org/240533003/diff/1/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/240533003/diff/1/include/core/SkXfermode.h#ne...
include/core/SkXfermode.h:255: This class is not exported to java.
Hoooray!

[scroggo, 2014-04-16 22:02:03]

lgtm

https://codereview.chromium.org/240533003/diff/1/src/utils/debugger/SkDebugCa...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/240533003/diff/1/src/utils/debugger/SkDebugCa...
src/utils/debugger/SkDebugCanvas.cpp:123: virtual void toString(SkString* str)
const { str->set("OverdrawXfermode"); }
I'm not very familiar with toString. Does this need to be inside some #ifdef?
(Or is it already since this is a debug file?)

[reed1, 2014-04-17 12:24:13]

On 2014/04/16 22:02:03, scroggo wrote:
> lgtm
> 
>
https://codereview.chromium.org/240533003/diff/1/src/utils/debugger/SkDebugCa...
> File src/utils/debugger/SkDebugCanvas.cpp (right):
> 
>
https://codereview.chromium.org/240533003/diff/1/src/utils/debugger/SkDebugCa...
> src/utils/debugger/SkDebugCanvas.cpp:123: virtual void toString(SkString* str)
> const { str->set("OverdrawXfermode"); }
> I'm not very familiar with toString. Does this need to be inside some #ifdef?
> (Or is it already since this is a debug file?)

Hmm, good question.

[reed1, 2014-04-17 12:24:42]

I think this will bust old serialized pictures, so I won't try to land yet :(

[reed1, 2014-04-17 13:46:43]

On 2014/04/17 12:24:42, reed1 wrote:
> I think this will bust old serialized pictures, so I won't try to land yet :(

Actually, I think we're good.

[reed1, 2014-04-17 13:47:00]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-17 13:47:06]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/240533003/1

[commit-bot: I haz the power, 2014-04-17 13:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-17 13:47:11]

Failed to apply patch for tests/PaintTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tests/PaintTest.cpp
  Hunk #1 FAILED at 325.
  1 out of 1 hunk FAILED -- saving rejects to file tests/PaintTest.cpp.rej

Patch:       tests/PaintTest.cpp
Index: tests/PaintTest.cpp
diff --git a/tests/PaintTest.cpp b/tests/PaintTest.cpp
index
f6aede1200c5a2db57f6eb10a2301364160bc4e3..914e61e4b033ad47cab077277e7e538d0c1ec851
100644
--- a/tests/PaintTest.cpp
+++ b/tests/PaintTest.cpp
@@ -325,7 +325,7 @@ DEF_TEST(Paint_FlatteningTraits, r) {
 
     SkWriteBuffer writer;
     SkPaint::FlatteningTraits::Flatten(writer, paint);
-    const size_t expectedBytesWritten = sizeof(void*) == 8 ? 40 : 32;
+    const size_t expectedBytesWritten = sizeof(void*) == 8 ? 32 : 24;
     ASSERT(expectedBytesWritten == writer.bytesWritten());
 
     const uint32_t* written = writer.getWriter32()->contiguousArray();

[reed1, 2014-04-17 13:47:24]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-04-17 14:03:05]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-17 14:03:18]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/240533003/20001

[commit-bot: I haz the power, 2014-04-17 15:19:36]

Change committed as 14238