Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tests/XfermodeTest.cpp

Issue 240533003: Orphan ProcXfermode, with an eye towards removing it (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: guard toString Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/PaintTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/XfermodeTest.cpp
diff --git a/tests/XfermodeTest.cpp b/tests/XfermodeTest.cpp
index 4afa522de7af06aefc7b92f63e1a1e36aab57f6a..34f5233fcf4e5dda849f2a14649277aedaf195ef 100644
--- a/tests/XfermodeTest.cpp
+++ b/tests/XfermodeTest.cpp
@@ -9,10 +9,6 @@
#include "SkXfermode.h"
#include "Test.h"
-static SkPMColor bogusXfermodeProc(SkPMColor src, SkPMColor dst) {
- return 42;
-}
-
#define ILLEGAL_MODE ((SkXfermode::Mode)-1)
static void test_asMode(skiatest::Reporter* reporter) {
@@ -36,14 +32,6 @@ static void test_asMode(skiatest::Reporter* reporter) {
REPORTER_ASSERT(reporter, SkXfermode::kSrcOver_Mode == mode);
}
}
-
- SkXfermode* bogusXfer = SkProcXfermode::Create(bogusXfermodeProc);
- SkXfermode::Mode reportedMode = ILLEGAL_MODE;
- REPORTER_ASSERT(reporter, !bogusXfer->asMode(&reportedMode));
- REPORTER_ASSERT(reporter, reportedMode == ILLEGAL_MODE);
- REPORTER_ASSERT(reporter, !SkXfermode::AsMode(bogusXfer, &reportedMode));
- REPORTER_ASSERT(reporter, reportedMode == ILLEGAL_MODE);
- bogusXfer->unref();
}
static void test_IsMode(skiatest::Reporter* reporter) {
« no previous file with comments | « tests/PaintTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698