Mark ParseInfo as top-level in the constructors

Mark ParseInfo as top-level in the constructors

If we're parsing a script or based on a SharedFunctionInfo marked as toplevel, we can implicitly set it. Only manually set in the background parsing task where we manually set up ParseInfo.

BUG=v8:5501
Committed: https://crrev.com/8f66bb641eb5f17a473e5c94a29ec3b44f388d54
Cr-Commit-Position: refs/heads/master@{#40215}

[Toon Verwaest, 2016-10-12 11:10:55]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-10-12 11:10:56]

ptal

[marja, 2016-10-12 11:58:57]

lgtm w/ comments

https://codereview.chromium.org/2405263003/diff/1/src/parsing/parse-info.cc
File src/parsing/parse-info.cc (right):

https://codereview.chromium.org/2405263003/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:13: ParseInfo::ParseInfo(Zone* zone)
Why not also set is_toplevel here?

Then the backgroundparsing task and the other ctor calling this don't need to
set it either. We could just default to top level, and whoever is parsing
something else than top level scripts can set it.

https://codereview.chromium.org/2405263003/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:70: set_toplevel();
... and then this can go away since it's set in the other ctor.

[Toon Verwaest, 2016-10-12 12:17:54]

https://codereview.chromium.org/2405263003/diff/1/src/parsing/parse-info.cc
File src/parsing/parse-info.cc (right):

https://codereview.chromium.org/2405263003/diff/1/src/parsing/parse-info.cc#n...
src/parsing/parse-info.cc:13: ParseInfo::ParseInfo(Zone* zone)
On 2016/10/12 11:58:57, marja wrote:
> Why not also set is_toplevel here?
> 
> Then the backgroundparsing task and the other ctor calling this don't need to
> set it either. We could just default to top level, and whoever is parsing
> something else than top level scripts can set it.

Why is that a better default? Note that in the other constructors we'd have to
possibly set_toplevel(false) in that case. Also background parsing tasks in the
compiler dispatcher will have to set it to false.

[Toon Verwaest, 2016-10-12 12:22:28]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-10-12 12:22:28]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2405263003/#ps20001
(title: "just set the flag")

[commit-bot: I haz the power, 2016-10-12 12:22:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 12:51:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 12:51:32]

Description was changed from

==========
Mark ParseInfo as top-level in the constructors

If we're parsing a script or based on a SharedFunctionInfo marked as toplevel,
we can implicitly set it. Only manually set in the background parsing task where
we manually set up ParseInfo.

BUG=v8:5501
==========

to

==========
Mark ParseInfo as top-level in the constructors

If we're parsing a script or based on a SharedFunctionInfo marked as toplevel,
we can implicitly set it. Only manually set in the background parsing task where
we manually set up ParseInfo.

BUG=v8:5501

Committed: https://crrev.com/8f66bb641eb5f17a473e5c94a29ec3b44f388d54
Cr-Commit-Position: refs/heads/master@{#40215}
==========

[commit-bot: I haz the power, 2016-10-12 12:51:33]

Patchset 2 (id:??) landed as
https://crrev.com/8f66bb641eb5f17a473e5c94a29ec3b44f388d54
Cr-Commit-Position: refs/heads/master@{#40215}