Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: src/debug/debug-scopes.cc

Issue 2405263003: Mark ParseInfo as top-level in the constructors (Closed)
Patch Set: just set the flag Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/parsing/parse-info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug-scopes.h" 5 #include "src/debug/debug-scopes.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 } 86 }
87 87
88 // Reparse the code and analyze the scopes. 88 // Reparse the code and analyze the scopes.
89 // Check whether we are in global, eval or function code. 89 // Check whether we are in global, eval or function code.
90 Zone zone(isolate->allocator()); 90 Zone zone(isolate->allocator());
91 std::unique_ptr<ParseInfo> info; 91 std::unique_ptr<ParseInfo> info;
92 if (scope_info->scope_type() != FUNCTION_SCOPE) { 92 if (scope_info->scope_type() != FUNCTION_SCOPE) {
93 // Global or eval code. 93 // Global or eval code.
94 Handle<Script> script(Script::cast(shared_info->script())); 94 Handle<Script> script(Script::cast(shared_info->script()));
95 info.reset(new ParseInfo(&zone, script)); 95 info.reset(new ParseInfo(&zone, script));
96 info->set_toplevel();
97 if (scope_info->scope_type() == EVAL_SCOPE) { 96 if (scope_info->scope_type() == EVAL_SCOPE) {
98 info->set_eval(); 97 info->set_eval();
99 if (!function->context()->IsNativeContext()) { 98 if (!function->context()->IsNativeContext()) {
100 info->set_outer_scope_info(handle(function->context()->scope_info())); 99 info->set_outer_scope_info(handle(function->context()->scope_info()));
101 } 100 }
102 // Language mode may be inherited from the eval caller. 101 // Language mode may be inherited from the eval caller.
103 // Retrieve it from shared function info. 102 // Retrieve it from shared function info.
104 info->set_language_mode(shared_info->language_mode()); 103 info->set_language_mode(shared_info->language_mode());
105 } else { 104 } else {
106 DCHECK(scope_info->scope_type() == SCRIPT_SCOPE); 105 DCHECK(scope_info->scope_type() == SCRIPT_SCOPE);
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 DCHECK((beg_pos >= 0 && end_pos >= 0) || inner_scope->is_hidden()); 831 DCHECK((beg_pos >= 0 && end_pos >= 0) || inner_scope->is_hidden());
833 if (beg_pos <= position && position < end_pos) { 832 if (beg_pos <= position && position < end_pos) {
834 GetNestedScopeChain(isolate, inner_scope, position); 833 GetNestedScopeChain(isolate, inner_scope, position);
835 return; 834 return;
836 } 835 }
837 } 836 }
838 } 837 }
839 838
840 } // namespace internal 839 } // namespace internal
841 } // namespace v8 840 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/parsing/parse-info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698