Ensure valid input for CompositeEditCommand::moveParagraph[s]

third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

 /*
  * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 277 matching lines @@
     // Re-canonicalize visible{Start,End}OfParagraph, make them valid again
     // after DOM change.
     // TODO(xiaochengh): We should not store a VisiblePosition and later inspect
     // its properties when it is already invalidated.
     visibleStartOfParagraph =
         createVisiblePosition(visibleStartOfParagraph.toPositionWithAffinity());
     visibleEndOfParagraph =
         createVisiblePosition(visibleEndOfParagraph.toPositionWithAffinity());
   }
 
+  // TODO(xiaochengh): We should not store a VisiblePosition and later inspect
+  // its properties when it is already invalidated.
   VisiblePosition startOfParagraphToMove =
       startOfParagraph(visibleStartOfParagraph);
   VisiblePosition endOfParagraphToMove = endOfParagraph(visibleEndOfParagraph);
   if (startOfParagraphToMove.isNull() || endOfParagraphToMove.isNull())
     return;
   HTMLBRElement* placeholder = HTMLBRElement::create(document());
   insertNodeBefore(placeholder, splitBlockquoteNode, editingState);
   if (editingState->isAborted())
     return;
 
   document().updateStyleAndLayoutIgnorePendingStylesheets();
+  startOfParagraphToMove =
+      createVisiblePosition(startOfParagraphToMove.toPositionWithAffinity());
+  endOfParagraphToMove =
+      createVisiblePosition(endOfParagraphToMove.toPositionWithAffinity());
   moveParagraph(startOfParagraphToMove, endOfParagraphToMove,
                 VisiblePosition::beforeNode(placeholder), editingState,
                 PreserveSelection);
 }
 
 // FIXME: We should merge this function with
 // ApplyBlockElementCommand::formatSelection
 void IndentOutdentCommand::outdentRegion(
     const VisiblePosition& startOfSelection,
     const VisiblePosition& endOfSelection,
@@ skipping 69 matching lines @@
   else
     indentIntoBlockquote(start, end, blockquoteForNextIndent, editingState);
 }
 
 InputEvent::InputType IndentOutdentCommand::inputType() const {
   return m_typeOfAction == Indent ? InputEvent::InputType::Indent
                                   : InputEvent::InputType::Outdent;
 }
 
 }  // namespace blink