Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2405173007: [Interpreter] Print information about interpreted functions when tracing ics. (Closed)

Created:
4 years, 2 months ago by mythria
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Print information about interpreted functions when tracing ics. With --trace-ic flag, the function names and the source positions are not shown for interpreted functions. Interpreted functions have an extra frame built by bytecode handlers which has to be skipped to get the interpreted function's frame. Also the code offsets are computed differently for interpreted functions. BUG=v8:4280 Committed: https://crrev.com/6fa76d461bf0d74f214a872c5d884572dd58dc50 Cr-Commit-Position: refs/heads/master@{#40274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -10 lines) Patch
M src/frames.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/frames.cc View 3 chunks +26 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mythria
This cl is to fix the output generated for interpreted functions with --trace-ic flag. PTAL. ...
4 years, 2 months ago (2016-10-13 13:45:00 UTC) #6
Leszek Swirski
I'm not sure I understand the change in the IC constructor entirely, but otherwise this ...
4 years, 2 months ago (2016-10-13 13:54:37 UTC) #7
mvstanton
Right on, we need this output. LGTM.
4 years, 2 months ago (2016-10-13 13:58:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405173007/1
4 years, 2 months ago (2016-10-13 14:28:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 14:47:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:48:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fa76d461bf0d74f214a872c5d884572dd58dc50
Cr-Commit-Position: refs/heads/master@{#40274}

Powered by Google App Engine
This is Rietveld 408576698