Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3913)

Unified Diff: chrome/browser/interstitials/chrome_metrics_helper.h

Issue 2405013002: Move some global feature defines to buildflags (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/interstitials/chrome_metrics_helper.h
diff --git a/chrome/browser/interstitials/chrome_metrics_helper.h b/chrome/browser/interstitials/chrome_metrics_helper.h
index 9d5de223b2ea944034320582ab74599c10c5cbd3..15736ded329ffb1cf31020d612fdba84007e3d11 100644
--- a/chrome/browser/interstitials/chrome_metrics_helper.h
+++ b/chrome/browser/interstitials/chrome_metrics_helper.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/macros.h"
+#include "chrome/common/features.h"
#include "components/security_interstitials/core/metrics_helper.h"
#include "url/gurl.h"
@@ -46,7 +47,7 @@ class ChromeMetricsHelper : public security_interstitials::MetricsHelper {
void RecordExtraShutdownMetrics() override;
private:
-#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION) || defined(ENABLE_EXTENSIONS)
+#if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION) || defined(ENABLE_EXTENSIONS)
content::WebContents* web_contents_;
#endif
const GURL request_url_;
@@ -54,7 +55,7 @@ class ChromeMetricsHelper : public security_interstitials::MetricsHelper {
#if defined(ENABLE_EXTENSIONS)
std::unique_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
#endif
-#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
+#if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION)
std::unique_ptr<CaptivePortalMetricsRecorder> captive_portal_recorder_;
#endif

Powered by Google App Engine
This is Rietveld 408576698