Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: cc/output/output_surface.h

Issue 2404993002: cc: Stop calling DetachFromClient if bind failed. (Closed)
Patch Set: detachinternal: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/compositor_frame_sink.cc ('k') | cc/surfaces/direct_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/output_surface.h
diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h
index 172858fa3b617216e9cd1db419131a1346bb2fb1..c1045645b75a00bf6def4dba95897a327bb78931 100644
--- a/cc/output/output_surface.h
+++ b/cc/output/output_surface.h
@@ -68,12 +68,9 @@ class CC_EXPORT OutputSurface {
virtual ~OutputSurface();
// Called by the compositor on the compositor thread. This is a place where
- // thread-specific data for the output surface can be initialized, since from
- // this point to when DetachFromClient() is called the output surface will
- // only be used on the compositor thread.
- // The caller should call DetachFromClient() on the same thread before
- // destroying the OutputSurface, even if this fails. And BindToClient should
- // not be called twice for a given OutputSurface.
+ // thread-specific data for the output surface can be initialized. The
+ // OutputSurface will be destroyed on the same thread that BoundToClient is
+ // called on.
virtual bool BindToClient(OutputSurfaceClient* client);
const Capabilities& capabilities() const { return capabilities_; }
« no previous file with comments | « cc/output/compositor_frame_sink.cc ('k') | cc/surfaces/direct_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698