Remove SafeSearchURLCheckerTest.Equivalence which doesn't test anything

Remove SafeSearchURLCheckerTest.Equivalence which doesn't test anything

SafeSearchURLCheckerTest.Equivalence contains three unused variables
named |url_response|. After removing these unused variables, the test
only verifies that the callback is called, which is already covered
by SafeSearchURLCheckerTest.Simple.

The test hints at URL normalization functionality which is, however,
not implemented.

BUG=653479
Committed: https://crrev.com/f97276943c4780c90a28c8062f00b171ef89f6c4
Cr-Commit-Position: refs/heads/master@{#424410}

[msramek, 2016-10-10 18:19:11]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:19:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 18:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:50:03]

Dry run: This issue passed the CQ dry run.

[msramek, 2016-10-10 20:10:13]

msramek@chromium.org changed reviewers:
+ treib@chromium.org

[msramek, 2016-10-10 20:10:14]

Hi Marc,

PTAL!

I noticed this while writing the previous CL. I hope I'm not missing something
obvious :)

On the other hand - if you want that functionality, I can implement it; it
sounds useful. Even though we might use something even broader for our usecase.

Thanks,
Martin

[Marc Treib, 2016-10-11 12:40:30]

lgtm

Nice catch!

I think this is a historic artifact: Before the SafeSearch API existed, we had a
prototype implementation that did some manual normalization. Now all that should
be handled on the server side, so no need to do anything in Chrome.

[msramek, 2016-10-11 12:43:34]

On 2016/10/11 12:40:30, Marc Treib wrote:
> lgtm
> 
> Nice catch!
> 
> I think this is a historic artifact: Before the SafeSearch API existed, we had
a
> prototype implementation that did some manual normalization. Now all that
should
> be handled on the server side, so no need to do anything in Chrome.

Good to know! Thanks :)

[msramek, 2016-10-11 12:43:45]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2016-10-11 12:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 12:49:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-11 12:51:06]

Description was changed from

==========
Remove SafeSearchURLCheckerTest.Equivalence which doesn't test anything

SafeSearchURLCheckerTest.Equivalence contains three unused variables
named |url_response|. After removing these unused variables, the test
only verifies that the callback is called, which is already covered
by SafeSearchURLCheckerTest.Simple.

The test hints at URL normalization functionality which is, however,
not implemented.

BUG=653479
==========

to

==========
Remove SafeSearchURLCheckerTest.Equivalence which doesn't test anything

SafeSearchURLCheckerTest.Equivalence contains three unused variables
named |url_response|. After removing these unused variables, the test
only verifies that the callback is called, which is already covered
by SafeSearchURLCheckerTest.Simple.

The test hints at URL normalization functionality which is, however,
not implemented.

BUG=653479

Committed: https://crrev.com/f97276943c4780c90a28c8062f00b171ef89f6c4
Cr-Commit-Position: refs/heads/master@{#424410}
==========

[commit-bot: I haz the power, 2016-10-11 12:51:07]

Patchset 1 (id:??) landed as
https://crrev.com/f97276943c4780c90a28c8062f00b171ef89f6c4
Cr-Commit-Position: refs/heads/master@{#424410}