Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3758)

Unified Diff: chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc

Issue 2404933002: Remove SafeSearchURLCheckerTest.Equivalence which doesn't test anything (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc
diff --git a/chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc b/chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc
index b3c71c2ba938396288f3818f2a87696dffdb48c2..a842d81593f7e404069ab04bc8fbe40fc915fb74 100644
--- a/chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc
+++ b/chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc
@@ -135,33 +135,6 @@ TEST_F(SafeSearchURLCheckerTest, Simple) {
}
}
-TEST_F(SafeSearchURLCheckerTest, Equivalence) {
- // Leading "www." in the response should be ignored.
- {
- GURL url("http://example.com");
- GURL url_response("http://www.example.com");
- ASSERT_FALSE(CheckURL(url));
- EXPECT_CALL(*this, OnCheckDone(url, Classification::SAFE, false));
- SendValidResponse(false);
- }
- // Scheme should be ignored.
- {
- GURL url("http://www.example2.com");
- GURL url_response("https://www.example2.com");
- ASSERT_FALSE(CheckURL(url));
- EXPECT_CALL(*this, OnCheckDone(url, Classification::SAFE, false));
- SendValidResponse(false);
- }
- // Both at the same time should work as well.
- {
- GURL url("http://example3.com");
- GURL url_response("https://www.example3.com");
- ASSERT_FALSE(CheckURL(url));
- EXPECT_CALL(*this, OnCheckDone(url, Classification::SAFE, false));
- SendValidResponse(false);
- }
-}
-
TEST_F(SafeSearchURLCheckerTest, Cache) {
// One more URL than fit in the cache.
ASSERT_EQ(2u, kCacheSize);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698