Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2404923002: Fix BidirectionalStreamTest#testFailures flake (Closed)

Created:
4 years, 2 months ago by xunjieli
Modified:
4 years, 2 months ago
Reviewers:
mgersh
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BidirectionalStreamTest#testFailures flake When we cancel the request in BidirectionalStream#onStreamReady(), it's not guaranteed that the request is stopped right away, so we might have non-null connect timing. This CL makes the test assertion looser. BUG=653654 Committed: https://crrev.com/9be380db89ba5afe42e956b6cf240bd6036e51e6 Cr-Commit-Position: refs/heads/master@{#424188}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java View 1 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xunjieli
4 years, 2 months ago (2016-10-10 17:23:21 UTC) #2
mgersh
lgtm
4 years, 2 months ago (2016-10-10 18:11:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404923002/20001
4 years, 2 months ago (2016-10-10 18:11:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 18:25:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 18:29:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9be380db89ba5afe42e956b6cf240bd6036e51e6
Cr-Commit-Position: refs/heads/master@{#424188}

Powered by Google App Engine
This is Rietveld 408576698