Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2404923002: Fix BidirectionalStreamTest#testFailures flake (Closed)
Patch Set: self review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
index 378b09560940484c07bd6168f94214a5908bed8a..f7b8415afb9f1c4ba581efc848429d1899d8cf07 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
@@ -1197,14 +1197,8 @@ public class BidirectionalStreamTest extends CronetTestBase {
assertTrue(metrics.getSentBytesCount() > 0);
assertTrue(metrics.getReceivedBytesCount() > 0);
} else if (failureStep == ResponseStep.ON_STREAM_READY) {
- // onStreamReady() happens before response headers are received, so
- // there is no connect timing metrics.
assertNotNull(metrics.getRequestStart());
MetricsTestUtil.assertAfter(metrics.getRequestStart(), startTime);
- MetricsTestUtil.checkNoConnectTiming(metrics);
- // metrics.getResponseStart() can be null or non null
- // TODO(xunjieli): It's weird to have a null response start but a
- // non-null response end.
assertNotNull(metrics.getRequestEnd());
MetricsTestUtil.assertAfter(endTime, metrics.getRequestEnd());
// Entire request should take more than 0 ms
@@ -1219,14 +1213,9 @@ public class BidirectionalStreamTest extends CronetTestBase {
mTestFramework.mCronetEngine.removeRequestFinishedListener(requestFinishedListener);
}
- /*
- Disabled temporarily due to http://crbug.com/653654
-
@SmallTest
@Feature({"Cronet"})
@OnlyRunNativeCronet
- */
- @DisabledTest
public void testFailures() throws Exception {
throwOrCancel(FailureType.CANCEL_SYNC, ResponseStep.ON_STREAM_READY, false);
throwOrCancel(FailureType.CANCEL_ASYNC, ResponseStep.ON_STREAM_READY, false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698