[Remoting Android] Change talkback for the navigation drawer button

[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496
Committed: https://crrev.com/931ea7b071f5e90391e1682f6f371d2ba20b32ff
Cr-Commit-Position: refs/heads/master@{#425203}

[Yuwei, 2016-10-10 23:43:01]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org, lambroslambrou@chromium.org

[Yuwei, 2016-10-10 23:43:01]

PTAL. Thanks!

[Jamie, 2016-10-11 17:12:30]

On 2016/10/10 23:43:01, Yuwei wrote:
> PTAL. Thanks!

Is "Navigation drawer" a standard term used by other Android apps with talkback
enabled? I don't think I would know what it refers to if I hadn't been involved
in the dev process. If it's what every app uses then it will be familiar to
users who use the feature, but if not, we should call it something more
descriptive.

[Yuwei, 2016-10-11 18:11:29]

On 2016/10/11 17:12:30, Jamie wrote:
> On 2016/10/10 23:43:01, Yuwei wrote:
> > PTAL. Thanks!
> 
> Is "Navigation drawer" a standard term used by other Android apps with
talkback
> enabled? I don't think I would know what it refers to if I hadn't been
involved
> in the dev process. If it's what every app uses then it will be familiar to
> users who use the feature, but if not, we should call it something more
> descriptive.

"Navigation drawer" isn't used often. Since the drawer toggle is created as
```
mDrawerToggle = new ActionBarDrawerToggle(this, mDrawerLayout, toolbar,
                R.string.open_navigation_drawer,
R.string.close_navigation_drawer)
```

I think it was supposed to announce "Open navigation drawer", although that code
doesn't work...

To be descriptive I think I can change it to "Menu button" as Jon suggested.

[Yuwei, 2016-10-11 18:46:56]

PTAL

On 2016/10/11 17:12:30, Jamie wrote:
> On 2016/10/10 23:43:01, Yuwei wrote:
> > PTAL. Thanks!
> 
> Is "Navigation drawer" a standard term used by other Android apps with
talkback
> enabled? I don't think I would know what it refers to if I hadn't been
involved
> in the dev process. If it's what every app uses then it will be familiar to
> users who use the feature, but if not, we should call it something more
> descriptive.

Changed the description to "Menu". Note that talkback will announce "menu
button" when you set the button description to "Menu".

[Yuwei, 2016-10-11 18:47:59]

Description was changed from

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Open
navigation drawer". Previously the default talkback was "navigate up".

BUG=650496
==========

to

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496
==========

[Lambros, 2016-10-11 23:20:47]

lgtm

https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:247:
R.string.open_navigation_drawer, R.string.close_navigation_drawer) {
I guess these string resource IDs don't actually get used in the implementation?
I think our call below:
mDrawerToggle.setDrawerIndicatorEnabled(false);
causes the animated 3-line icon to not be displayed, and I guess it also causes
the above IDs to also be ignored? Maybe look at the source code for
ActionBarDrawerToggle to see what's going on here?
Maybe replace these IDs with 0, or with your new "Menu" string, then delete the
unused strings?

[Yuwei, 2016-10-13 22:52:54]

On 2016/10/11 23:20:47, Lambros wrote:
> lgtm

Thanks!

>
https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/s...
> File remoting/android/java/src/org/chromium/chromoting/Chromoting.java
(right):
> 
>
https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/s...
> remoting/android/java/src/org/chromium/chromoting/Chromoting.java:247:
> R.string.open_navigation_drawer, R.string.close_navigation_drawer) {
> I guess these string resource IDs don't actually get used in the
implementation?
> I think our call below:
> mDrawerToggle.setDrawerIndicatorEnabled(false);
> causes the animated 3-line icon to not be displayed, and I guess it also
causes
> the above IDs to also be ignored? Maybe look at the source code for
> ActionBarDrawerToggle to see what's going on here?

That's probably the reason. ActionBarDrawerToggle calls
setHomeActionContentDescription(contentDescRes) on the abstract actionbar, then
I lose track :)

> Maybe replace these IDs with 0, or with your new "Menu" string, then delete
the
> unused strings?

Done.

[Yuwei, 2016-10-13 22:54:19]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-10-13 22:54:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/2404903003/#ps40001
(title: "Reviewer's Feedback")

[commit-bot: I haz the power, 2016-10-13 22:54:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 23:34:26]

Description was changed from

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496
==========

to

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496
==========

[commit-bot: I haz the power, 2016-10-13 23:34:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 23:37:28]

Description was changed from

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496
==========

to

==========
[Remoting Android] Change talkback for the navigation drawer button

This CL changes the talkback for the navigation drawer button to "Menu button".
Previously the default talkback was "navigate up button".

BUG=650496

Committed: https://crrev.com/931ea7b071f5e90391e1682f6f371d2ba20b32ff
Cr-Commit-Position: refs/heads/master@{#425203}
==========

[commit-bot: I haz the power, 2016-10-13 23:37:29]

Patchset 3 (id:??) landed as
https://crrev.com/931ea7b071f5e90391e1682f6f371d2ba20b32ff
Cr-Commit-Position: refs/heads/master@{#425203}