Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2404903003: [Remoting Android] Change talkback for the navigation drawer button (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros, joedow
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Change talkback for the navigation drawer button This CL changes the talkback for the navigation drawer button to "Menu button". Previously the default talkback was "navigate up button". BUG=650496 Committed: https://crrev.com/931ea7b071f5e90391e1682f6f371d2ba20b32ff Cr-Commit-Position: refs/heads/master@{#425203}

Patch Set 1 #

Patch Set 2 : Reviewer's Feedback #

Total comments: 1

Patch Set 3 : Reviewer's Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 1 2 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yuwei
PTAL. Thanks!
4 years, 2 months ago (2016-10-10 23:43:01 UTC) #2
Jamie
On 2016/10/10 23:43:01, Yuwei wrote: > PTAL. Thanks! Is "Navigation drawer" a standard term used ...
4 years, 2 months ago (2016-10-11 17:12:30 UTC) #3
Yuwei
On 2016/10/11 17:12:30, Jamie wrote: > On 2016/10/10 23:43:01, Yuwei wrote: > > PTAL. Thanks! ...
4 years, 2 months ago (2016-10-11 18:11:29 UTC) #4
Yuwei
PTAL On 2016/10/11 17:12:30, Jamie wrote: > On 2016/10/10 23:43:01, Yuwei wrote: > > PTAL. ...
4 years, 2 months ago (2016-10-11 18:46:56 UTC) #5
Lambros
lgtm https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode247 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:247: R.string.open_navigation_drawer, R.string.close_navigation_drawer) { I guess these string resource ...
4 years, 2 months ago (2016-10-11 23:20:47 UTC) #7
Yuwei
On 2016/10/11 23:20:47, Lambros wrote: > lgtm Thanks! > https://codereview.chromium.org/2404903003/diff/20001/remoting/android/java/src/org/chromium/chromoting/Chromoting.java > File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): > ...
4 years, 2 months ago (2016-10-13 22:52:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404903003/40001
4 years, 2 months ago (2016-10-13 22:54:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 23:34:27 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 23:37:29 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/931ea7b071f5e90391e1682f6f371d2ba20b32ff
Cr-Commit-Position: refs/heads/master@{#425203}

Powered by Google App Engine
This is Rietveld 408576698