Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: appengine/swarming/proto/config.proto

Issue 2404883002: Add links to MP and resolve minor fixes (Closed)
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/proto/config.proto
diff --git a/appengine/swarming/proto/config.proto b/appengine/swarming/proto/config.proto
index d3f29faded327c43a1dc0cea104a3755eb32269c..99779869830dd620cacdca3a79f3c1e458218b91 100644
--- a/appengine/swarming/proto/config.proto
+++ b/appengine/swarming/proto/config.proto
@@ -38,6 +38,14 @@ message SettingsCfg {
// A mapping "dimension" => "who can posts tasks for it".
optional DimensionACLs dimension_acls = 10;
+
+ // A partial url which a task id will be appended. The result should be a
+ // valid link to the milo output of a task (if any).
+ optional string milo_server_prefix = 11;
+
+ // A partial url which a Skia git revision will be appended. The result
M-A Ruel 2016/10/11 16:26:55 I think we need a more generic way to define this
kjlubick 2016/10/11 17:00:03 I agree. I'll rework this to deal with a tag inst
kjlubick 2016/10/12 13:59:51 As it turns out, there was a sk_repo tag already b
+ // should be a valid link to the source code at that revision (if any).
+ optional string sk_revision_prefix = 12;
}

Powered by Google App Engine
This is Rietveld 408576698