Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2341)

Unified Diff: appengine/swarming/handlers_endpoints.py

Issue 2404883002: Add links to MP and resolve minor fixes (Closed)
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/handlers_endpoints.py
diff --git a/appengine/swarming/handlers_endpoints.py b/appengine/swarming/handlers_endpoints.py
index 03302a2f6f571d89a570ef1763687c58b093fa94..7231eee7a45d18c269d04c4ec95d7ef3d35b8447 100644
--- a/appengine/swarming/handlers_endpoints.py
+++ b/appengine/swarming/handlers_endpoints.py
@@ -135,9 +135,18 @@ class SwarmingServerService(remote.Service):
def details(self, _request):
"""Returns information about the server."""
host = 'https://' + os.environ['HTTP_HOST']
+
+ mpp = ""
M-A Ruel 2016/10/11 16:26:55 Use single quotes.
kjlubick 2016/10/11 17:00:02 Done.
+ logging.info("Settings: %s",config.settings())
M-A Ruel 2016/10/11 16:26:55 you should log the returned object if you want to
kjlubick 2016/10/11 17:00:02 Oops, left over logging. Removed.
+ if config.settings().mp and config.settings().mp.server:
+ mpp = config.settings().mp.server
+
return swarming_rpcs.ServerDetails(
bot_version = bot_code.get_bot_version(host),
- server_version = utils.get_app_version())
+ server_version = utils.get_app_version(),
+ machine_provider_prefix = mpp,
+ milo_prefix = config.settings().milo_server_prefix,
+ sk_revision_prefix = config.settings().sk_revision_prefix)
@gae_ts_mon.instrument_endpoint()
@auth.endpoints_method(

Powered by Google App Engine
This is Rietveld 408576698