Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2569)

Unified Diff: appengine/swarming/elements/res/imp/tasklist/task-list.html

Issue 2404883002: Add links to MP and resolve minor fixes (Closed)
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/tasklist/task-list.html
diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html
index d0be40c41e89ff8ab7f069f5a8c4c6faddfd3aa0..cc444ba3fce272999d011aeef6990f3cdffec963 100644
--- a/appengine/swarming/elements/res/imp/tasklist/task-list.html
+++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html
@@ -64,6 +64,7 @@
auth_headers="{{_auth_headers}}"
permissions="{{_permissions}}"
signed_in="{{_signed_in}}"
+ server_details="{{_server_details}}"
busy="[[_or(_busy1,_busy2)]]"
name="Swarming Task List">
@@ -204,7 +205,7 @@
<td hidden$="[[_hide('sk_revision', _columns.*)]]">
<a
class="center"
- href$="[[_skLink(task)]]"
+ href$="[[_skLink(task, _server_details.sk_revision_prefix)]]"
target="_blank">
[[_column('sk_revision',task)]]
</a>
@@ -248,7 +249,7 @@
</template>
<script>
(function(){
- var specialColumns = ["deduped_from", "name", "state", "bot"];
+ var specialColumns = ["deduped_from", "name", "state", "bot", "sk_revision"];
// Given a time attribute like "abandoned_ts", humanTime returns a function
// that returns the human-friendly version of that attribute. The human
@@ -422,12 +423,12 @@
this.$.page_tasks.load(url,this._auth_headers);
},
- _skLink: function(task) {
+ _skLink: function(task, sk_revision_prefix) {
var r = this._attribute(task, "sk_revision")[0];
- if (r === "none") {
+ if (r === "none" || !sk_revision_prefix) {
return false;
}
- return "https://skia.googlesource.com/skia/+/" + r;
+ return sk_revision_prefix + r;
},
_tag: function(task, col) {

Powered by Google App Engine
This is Rietveld 408576698