Chromium Code Reviews| Index: appengine/swarming/elements/res/imp/tasklist/task-list.html |
| diff --git a/appengine/swarming/elements/res/imp/tasklist/task-list.html b/appengine/swarming/elements/res/imp/tasklist/task-list.html |
| index d0be40c41e89ff8ab7f069f5a8c4c6faddfd3aa0..2b7b0b4b8011ba053dfdc78aa9fe5958e590042d 100644 |
| --- a/appengine/swarming/elements/res/imp/tasklist/task-list.html |
| +++ b/appengine/swarming/elements/res/imp/tasklist/task-list.html |
| @@ -136,10 +136,10 @@ |
| </sort-toggle> |
| </th> |
| - <th hidden$="[[_hide('sk_revision', _columns.*)]]"> |
| - <span>Skia Revision</span> |
| + <th hidden$="[[_hide('source_revision', _columns.*)]]"> |
| + <span>Source Revision</span> |
| <sort-toggle |
| - name="sk_revision" |
| + name="source_revision" |
| current="[[_sort]]"> |
| </sort-toggle> |
| </th> |
| @@ -201,12 +201,12 @@ |
| </a> |
| </td> |
| - <td hidden$="[[_hide('sk_revision', _columns.*)]]"> |
| + <td hidden$="[[_hide('source_revision', _columns.*)]]"> |
| <a |
| class="center" |
| href$="[[_skLink(task)]]" |
| target="_blank"> |
| - [[_column('sk_revision',task)]] |
| + [[_column('source_revision',task)]] |
| </a> |
| </td> |
| @@ -248,7 +248,7 @@ |
| </template> |
| <script> |
| (function(){ |
| - var specialColumns = ["deduped_from", "name", "state", "bot"]; |
| + var specialColumns = ["deduped_from", "name", "state", "bot", "source_revision"]; |
| // Given a time attribute like "abandoned_ts", humanTime returns a function |
| // that returns the human-friendly version of that attribute. The human |
| @@ -270,8 +270,8 @@ |
| created_ts: humanTime("created_ts"), |
| duration: humanTime("duration"), |
| modified_ts: humanTime("modified_ts"), |
| - sk_revision: function(task) { |
| - var r = this._attribute(task, "sk_revision")[0]; |
| + source_revision: function(task) { |
| + var r = this._attribute(task, "source_revision")[0]; |
| return r.substring(0,8); |
| }, |
| started_ts: humanTime("started_ts"), |
| @@ -423,11 +423,12 @@ |
| }, |
| _skLink: function(task) { |
|
jcgregorio
2016/10/13 12:03:45
Rename _skLink to _sourceLink.
kjlubick
2016/10/13 12:26:49
Done.
|
| - var r = this._attribute(task, "sk_revision")[0]; |
| - if (r === "none") { |
| + var rev = this._attribute(task, "source_revision")[0]; |
| + var repo = this._attribute(task, "source_repo")[0]; |
| + if (rev === "none" || repo === "none") { |
| return false; |
| } |
| - return "https://skia.googlesource.com/skia/+/" + r; |
| + return repo.replace("%s", rev); |
| }, |
| _tag: function(task, col) { |