Add links to MP and resolve minor fixes

appengine/swarming/elements/res/imp/tasklist/task-list.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <task-list>
 
@@ skipping 118 matching lines @@
               </th>
 
               <th hidden$="[[_hide('deduped_from', _columns.*)]]">
                 <span>Deduped from</span>
                 <sort-toggle
                     name="deduped_from"
                     current="[[_sort]]">
                 </sort-toggle>
               </th>
 
-              <th hidden$="[[_hide('sk_revision', _columns.*)]]">
-                <span>Skia Revision</span>
+              <th hidden$="[[_hide('source_revision', _columns.*)]]">
+                <span>Source Revision</span>
                 <sort-toggle
-                    name="sk_revision"
+                    name="source_revision"
                     current="[[_sort]]">
                 </sort-toggle>
               </th>
 
               <template
                     is="dom-repeat"
                     items="[[_plainColumns]]"
                     as="c">
                 <th hidden$="[[_hide(c)]]">
                   <span>[[_header(c)]]</span>
@@ skipping 41 matching lines @@
                 </td>
                 <td hidden$="[[_hide('deduped_from', _columns.*)]]">
                   <a
                       class="center"
                       href$="[[_taskLink(task.deduped_from)]]"
                       target="_blank">
                       [[_column('deduped_from',task)]]
                   </a>
                 </td>
 
-                <td hidden$="[[_hide('sk_revision', _columns.*)]]">
+                <td hidden$="[[_hide('source_revision', _columns.*)]]">
                   <a
                       class="center"
                       href$="[[_skLink(task)]]"
                       target="_blank">
-                      [[_column('sk_revision',task)]]
+                      [[_column('source_revision',task)]]
                   </a>
                 </td>
 
                 <template
                     is="dom-repeat"
                     items="[[_plainColumns]]"
                     as="c">
                   <td hidden$="[[_hide(c)]]">
                     [[_column(c, task)]]
                   </td>
@@ skipping 21 matching lines @@
         <paper-button dialog-dismiss autofocus>No</paper-button>
         <paper-button dialog-confirm>Yes</paper-button>
       </div>
     </paper-dialog>
 
     <error-toast></error-toast>
 
   </template>
   <script>
   (function(){
-    var specialColumns = ["deduped_from", "name", "state", "bot"];
+    var specialColumns = ["deduped_from", "name", "state", "bot", "source_revision"];
 
     // Given a time attribute like "abandoned_ts", humanTime returns a function
     // that returns the human-friendly version of that attribute. The human
     // friendly time was created in task-list-data.
     function humanTime(attr) {
       return function(task) {
         return this._attribute(task, "human_" + attr)[0];
       }
     }
     var columnMap = {
       abandoned_ts: humanTime("abandoned_ts"),
       bot: function(task) {
         return this._attribute(task, "bot_id")[0];
       },
       completed_ts: humanTime("completed_ts"),
       costs_usd: function(task) {
         return this._attribute(task, "costs_usd", 0)[0];
       },
       created_ts: humanTime("created_ts"),
       duration: humanTime("duration"),
       modified_ts: humanTime("modified_ts"),
-      sk_revision: function(task) {
-        var r = this._attribute(task, "sk_revision")[0];
+      source_revision: function(task) {
+        var r = this._attribute(task, "source_revision")[0];
         return r.substring(0,8);
       },
       started_ts: humanTime("started_ts"),
       state: function(task) {
         var state = this._attribute(task, "state")[0];
         if (state === "COMPLETED") {
 
           if (this._attribute(task, "failure", false)[0]) {
             return "COMPLETED (FAILURE)";
           }
@@ skipping 130 matching lines @@
       },
 
       reload: function() {
         if (!this._auth_headers || !this._query_params) {
           return;
         }
         var url = "/_ah/api/swarming/v1/tasks/list?" + sk.query.fromParamSet(this._query_params);
         this.$.page_tasks.load(url,this._auth_headers);
       },
 
       _skLink: function(task) {

[jcgregorio, 2016/10/13 12:03:45]

Rename _skLink to _sourceLink.

[kjlubick, 2016/10/13 12:26:49]

Done.

-        var r = this._attribute(task, "sk_revision")[0];
-        if (r === "none") {
+        var rev = this._attribute(task, "source_revision")[0];
+        var repo = this._attribute(task, "source_repo")[0];
+        if (rev === "none" || repo === "none") {
           return false;
         }
-        return "https://skia.googlesource.com/skia/+/" + r;
+        return repo.replace("%s", rev);
       },
 
       _tag: function(task, col) {
         if (!task || !task.tagMap) {
           return undefined;
         }
         return task.tagMap[col];
       },
 
       _taskClass: function(task) {
         return this.stateClass(this._column("state", task));
       }
     });
   })();
   </script>
 </dom-module>