Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout. (Closed)
Patch Set: address review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
index b991948fc11d2ae8bbdbd734b007b4528396ef94..d99e8acc414705fc9abeb604683c870ed260bd75 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
@@ -184,6 +184,7 @@ void ScrollableArea::setScrollOffset(const ScrollOffset& offset,
switch (scrollType) {
case CompositorScroll:
+ case ClampingScroll:
szager1 2016/10/13 17:54:49 I would have thought this would be treated like a
skobes 2016/10/13 18:00:31 Generally it is. The important difference is that
szager1 2016/10/13 18:50:56 This code path doesn't call cancelScrollAnimation(
bokan 2016/10/13 18:53:59 Perhaps programmaticScrollHelper should take a scr
skobes 2016/10/13 18:55:19 Basically, yes. I assumed that clamping cancellin
szager1 2016/10/13 19:00:39 I haven't thought too deeply about this, but my in
scrollOffsetChanged(clampedOffset, scrollType);
break;
case AnchoringScroll:

Powered by Google App Engine
This is Rietveld 408576698