third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2404393003: Tie scroll anchoring adjustments to frame lifecycle instead of layout. (Closed)

Patch Set: address review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 6a06e377bfc6ef12e09ece72292c01455913fcd9..f58086a5ba76ae935ab77a6f8d9e8504a2b76d09 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1997,6 +1997,7 @@ TEST_P(ParameterizedVisualViewportTest, ResizeWithScrollAnchoring) {

FrameView& frameView = *webViewImpl()->mainFrameImpl()->frameView();

frameView.layoutViewportScrollableArea()->setScrollOffset(

ScrollOffset(700, 500), ProgrammaticScroll);

+ webViewImpl()->updateAllLifecyclePhases();

webViewImpl()->resize(IntSize(800, 300));

EXPECT_SIZE_EQ(ScrollOffset(700, 200),