Issue 24042004: Check for correct behavior when invoking reflectClass() with incorrect arguments.

Issue 24042004: Check for correct behavior when invoking reflectClass() with incorrect arguments. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)

Modified:
7 years, 2 months ago

Reviewers:
ahe, rmacnak

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check for correct behavior when invoking reflectClass() with incorrect arguments. BUG=

Patch Set 3 : Addressed comments #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/lib/mirrors/reflect_class_test.dart	View	1 2	1 chunk	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/24042004/diff/1/tests/lib/mirrors/reflect_class_test.dart File tests/lib/mirrors/reflect_class_test.dart (right): https://codereview.chromium.org/24042004/diff/1/tests/lib/mirrors/reflect_class_test.dart#newcode26 tests/lib/mirrors/reflect_class_test.dart:26: // reflectClass() on a function type should fail once ...

7 years, 3 months ago (2013-09-10 19:59:00 UTC) #2

Michael Lippautz (Google)

7 years, 3 months ago (2013-09-10 20:05:39 UTC) #3

rmacnak

https://codereview.chromium.org/24042004/diff/6001/tests/lib/mirrors/reflect_class_test.dart File tests/lib/mirrors/reflect_class_test.dart (right): https://codereview.chromium.org/24042004/diff/6001/tests/lib/mirrors/reflect_class_test.dart#newcode9 tests/lib/mirrors/reflect_class_test.dart:9: // TODO(ahe,rmacnak): When both implementations agree, remove the multi-test ...

7 years, 3 months ago (2013-09-18 00:11:23 UTC) #5

Michael Lippautz (Google)

PTAL https://codereview.chromium.org/24042004/diff/6001/tests/lib/mirrors/reflect_class_test.dart File tests/lib/mirrors/reflect_class_test.dart (right): https://codereview.chromium.org/24042004/diff/6001/tests/lib/mirrors/reflect_class_test.dart#newcode9 tests/lib/mirrors/reflect_class_test.dart:9: // TODO(ahe,rmacnak): When both implementations agree, remove the ...

7 years, 3 months ago (2013-09-18 20:23:22 UTC) #6

rmacnak

7 years, 3 months ago (2013-09-18 22:52:05 UTC) #7

https://codereview.chromium.org/24042004/diff/11001/tests/lib/mirrors/reflect...
File tests/lib/mirrors/reflect_class_test.dart (right):

https://codereview.chromium.org/24042004/diff/11001/tests/lib/mirrors/reflect...
tests/lib/mirrors/reflect_class_test.dart:15: Expect.throws(() =>
reflectClass(1), expectedError);
These checks fail with TypeErrors in checked mode. Maybe we should skip this in
checked mode? Peter?

Expand Messages | Collapse Messages