Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2404143002: DevTools: move overview grid window curtains handling into said window (Closed)

Created:
4 years, 2 months ago by caseq
Modified:
4 years, 2 months ago
Reviewers:
alph
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move overview grid window curtains handling into said window This effectively reverts https://codereview.chromium.org/1427823002 and fixes the problem with selection curtains not properly shown for the paint profiler. Committed: https://crrev.com/e59db77e6259d8f70e50a734bad8e72de4658b56 Cr-Commit-Position: refs/heads/master@{#424854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -69 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 5 chunks +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineGrid.js View 3 chunks +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/overviewGrid.css View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/timelineGrid.css View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caseq
4 years, 2 months ago (2016-10-11 02:10:11 UTC) #2
alph
lgtm
4 years, 2 months ago (2016-10-12 18:58:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404143002/1
4 years, 2 months ago (2016-10-12 18:58:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:15:12 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:19:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e59db77e6259d8f70e50a734bad8e72de4658b56
Cr-Commit-Position: refs/heads/master@{#424854}

Powered by Google App Engine
This is Rietveld 408576698