Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 1427823002: DevTools: Grey out outside parts of selection window on timeline overview. (Closed)

Created:
5 years, 1 month ago by alph
Modified:
5 years, 1 month ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Grey out outside parts of selection window on timeline overview. Committed: https://crrev.com/1dbbfe571dad1ff36c8ddf03755d955f7137277f Cr-Commit-Position: refs/heads/master@{#357731}

Patch Set 1 #

Patch Set 2 : refactor #

Messages

Total messages: 14 (3 generated)
alph
5 years, 1 month ago (2015-10-28 21:24:11 UTC) #2
alph
ss: http://grab.by/LBGu
5 years, 1 month ago (2015-10-29 23:05:24 UTC) #4
alph
ping
5 years, 1 month ago (2015-10-30 18:33:24 UTC) #5
paulirish
Max made a mock for this guy a while ago. here it is: https://goo.gl/IHuYTY There's ...
5 years, 1 month ago (2015-10-30 21:20:14 UTC) #6
alph
On 2015/10/30 21:20:14, paulirish wrote: > Max made a mock for this guy a while ...
5 years, 1 month ago (2015-10-31 01:05:16 UTC) #7
paulirish
On 2015/10/31 at 01:05:16, alph wrote: > On 2015/10/30 21:20:14, paulirish wrote: > > Max ...
5 years, 1 month ago (2015-10-31 19:36:01 UTC) #8
alph
ping
5 years, 1 month ago (2015-11-03 22:04:20 UTC) #9
pfeldman
lgtm
5 years, 1 month ago (2015-11-03 23:03:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427823002/20001
5 years, 1 month ago (2015-11-03 23:06:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 02:23:19 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 02:23:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dbbfe571dad1ff36c8ddf03755d955f7137277f
Cr-Commit-Position: refs/heads/master@{#357731}

Powered by Google App Engine
This is Rietveld 408576698