Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 2404043002: Revert of Store only locale paks rather than all assets within BuildConfig.java (Closed)

Created:
4 years, 2 months ago by sgurun-gerrit only
Modified:
4 years, 2 months ago
Reviewers:
Ted C, michaelbai, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, Torne
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Store only locale paks rather than all assets within BuildConfig.java (patchset #2 id:20001 of https://codereview.chromium.org/2396073002/ ) Reason for revert: Breaking monochrome (chrome not booting up) BUG=652984, 653771 Original issue's description: > Store only locale paks rather than all assets within BuildConfig.java > > This works around Monochrome having diffferent BuildConfig.java for > 32/64 bit. > > BUG=652984 > > Committed: https://crrev.com/4e09dacc10a8a359785c6f49d75653ce7cfd00ec > Cr-Commit-Position: refs/heads/master@{#423587} TBR=tedchoc@chromium.org,michaelbai@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=652984 Committed: https://crrev.com/01fbbca601e78b594cebe62b8eb804ca7d6ff0aa Cr-Commit-Position: refs/heads/master@{#424304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 1 chunk +12 lines, -3 lines 0 comments Download
M base/android/java/templates/BuildConfig.template View 1 chunk +8 lines, -10 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +6 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sgurun-gerrit only
Created Revert of Store only locale paks rather than all assets within BuildConfig.java
4 years, 2 months ago (2016-10-10 22:49:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404043002/1
4 years, 2 months ago (2016-10-10 22:50:02 UTC) #3
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-11 00:33:17 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:35:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01fbbca601e78b594cebe62b8eb804ca7d6ff0aa
Cr-Commit-Position: refs/heads/master@{#424304}

Powered by Google App Engine
This is Rietveld 408576698