Issue 240403003: Adding lenient mode to WebRTC audio tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240403003: Adding lenient mode to WebRTC audio tests. (Closed)

Created:
6 years, 8 months ago by phoglund_chromium

Modified:
6 years, 8 months ago

Reviewers:
perkj_chrome

CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding lenient mode to audio tests. These tests are still flaky under TSAN and under Android, although the flake rates are very low now. It appears we cannot make many assumptions at all about the sample audio signal under such conditions, especially on outlier devices and bots. This test provides some value but should be more stable in those cases. BUG=357626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265305

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Passing parameter to test instead of global. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -24 lines)			Patch
M	content/browser/media/webrtc_browsertest.cc	View	1 2	4 chunks	+16 lines, -8 lines	0 comments	Download
M	content/test/data/media/peerconnection-call.html	View	1 2	5 chunks	+7 lines, -7 lines	0 comments	Download
M	content/test/data/media/webrtc_test_audio.js	View	1 2	2 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

The CQ bit was checked by phoglund@chromium.org

6 years, 8 months ago (2014-04-22 15:53:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/240403003/30001

6 years, 8 months ago (2014-04-22 15:55:17 UTC) #6

Message was sent while issue was closed.

Change committed as 265305

Expand Messages | Collapse Messages