third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl - Issue 2403893002: Add layout test for reply property of notificationclick event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

Issue 2403893002: Add layout test for reply property of notificationclick event (Closed)

Patch Set: Make reply field nullable in .idl files; add test cases for empty and null Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl b/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

index 913cdc8b0d9278e6d6ff87b914a5b034f4ee4f83..b1081e3ae6ec910fefb219781f73a8f4a1f66703 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

@@ -7,5 +7,5 @@

dictionary NotificationEventInit : ExtendableEventInit {

required Notification notification;

DOMString action = "";

- DOMString reply = "";

+ [RuntimeEnabled=NotificationInlineReplies] DOMString? reply = "";

};

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationEvent.idl ('k') | no next file » | no next file with comments »