third_party/WebKit/Source/modules/notifications/NotificationEvent.idl - Issue 2403893002: Add layout test for reply property of notificationclick event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationEvent.idl

Issue 2403893002: Add layout test for reply property of notificationclick event (Closed)

Patch Set: Make reply field nullable in .idl files; add test cases for empty and null Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reply-reflection.html ('k') | third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationEvent.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationEvent.idl b/third_party/WebKit/Source/modules/notifications/NotificationEvent.idl

index 863bab0d4a7f0806250a461b97eba25a756ec5d8..9e53d03c166fa9d71e81834fb84de200d1fbb967 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationEvent.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationEvent.idl

@@ -11,5 +11,5 @@

] interface NotificationEvent : ExtendableEvent {

[ImplementedAs=getNotification] readonly attribute Notification notification;

readonly attribute DOMString action;

- [RuntimeEnabled=NotificationInlineReplies] readonly attribute DOMString reply;

+ [RuntimeEnabled=NotificationInlineReplies] readonly attribute DOMString? reply;

};