extensions/renderer/gc_callback.cc - Issue 2403873003: [Extensions] Convert some callers of ScriptContext::CallFunction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/gc_callback.cc

Issue 2403873003: [Extensions] Convert some callers of ScriptContext::CallFunction (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/gc_callback.cc

diff --git a/extensions/renderer/gc_callback.cc b/extensions/renderer/gc_callback.cc

index 012189791ea23ec00409665861ce95281178015a..b3e471fd26059dc641fbe92c856c5490535e8f96 100644

--- a/extensions/renderer/gc_callback.cc

+++ b/extensions/renderer/gc_callback.cc

@@ -46,7 +46,8 @@ void GCCallback::RunCallback() {

fallback_.Reset();

v8::Isolate* isolate = context_->isolate();

v8::HandleScope handle_scope(isolate);

- context_->CallFunction(v8::Local<v8::Function>::New(isolate, callback_));

+ context_->SafeCallFunction(v8::Local<v8::Function>::New(isolate, callback_),

+ 0, nullptr);

delete this;

}