Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/renderer/extensions/cast_streaming_native_handler.cc

Issue 2403873003: [Extensions] Convert some callers of ScriptContext::CallFunction (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/gc_callback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/cast_streaming_native_handler.cc
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.cc b/chrome/renderer/extensions/cast_streaming_native_handler.cc
index 4fdaf2a2aef307aa8cefdece6af54d001300c549..6f504ac583783d6b36c4fd83427e1751aae816e2 100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.cc
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.cc
@@ -440,7 +440,7 @@ void CastStreamingNativeHandler::CallCreateCallback(
const int udp_id = last_transport_id_++;
udp_transport_map_[udp_id] = std::move(udp_transport);
callback_args[2] = v8::Integer::New(isolate, udp_id);
- context()->CallFunction(
+ context()->SafeCallFunction(
v8::Local<v8::Function>::New(isolate, create_callback_), 3,
callback_args);
create_callback_.Reset();
@@ -712,8 +712,8 @@ void CastStreamingNativeHandler::CallGetRawEventsCallback(
std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
v8::Local<v8::Value> callback_args[] = {
converter->ToV8Value(raw_events.get(), context()->v8_context())};
- context()->CallFunction(v8::Local<v8::Function>::New(isolate, it->second),
- arraysize(callback_args), callback_args);
+ context()->SafeCallFunction(v8::Local<v8::Function>::New(isolate, it->second),
+ arraysize(callback_args), callback_args);
get_raw_events_callbacks_.erase(it);
}
@@ -731,8 +731,8 @@ void CastStreamingNativeHandler::CallGetStatsCallback(
std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
v8::Local<v8::Value> callback_args[] = {
converter->ToV8Value(stats.get(), context()->v8_context())};
- context()->CallFunction(v8::Local<v8::Function>::New(isolate, it->second),
- arraysize(callback_args), callback_args);
+ context()->SafeCallFunction(v8::Local<v8::Function>::New(isolate, it->second),
+ arraysize(callback_args), callback_args);
get_stats_callbacks_.erase(it);
}
@@ -971,8 +971,8 @@ void CastStreamingNativeHandler::CallReceiverErrorCallback(
error_message.data(),
v8::String::kNormalString,
error_message.size());
- context()->CallFunction(
- v8::Local<v8::Function>::New(isolate, function), 1, &arg);
+ context()->SafeCallFunction(v8::Local<v8::Function>::New(isolate, function),
+ 1, &arg);
}
void CastStreamingNativeHandler::AddTracksToMediaStream(
« no previous file with comments | « no previous file | extensions/renderer/gc_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698