Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: components/autofill/core/browser/autofill_assistant_unittest.cc

Issue 2403773002: Remove stl_util's STLDeleteContainerPointers from autofill. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_assistant_unittest.cc
diff --git a/components/autofill/core/browser/autofill_assistant_unittest.cc b/components/autofill/core/browser/autofill_assistant_unittest.cc
index 16176f2af8f3087865e00c307b833cb19d44fb9c..44d0f0cec72692cc4df5c2c2798836d149caea5a 100644
--- a/components/autofill/core/browser/autofill_assistant_unittest.cc
+++ b/components/autofill/core/browser/autofill_assistant_unittest.cc
@@ -119,7 +119,8 @@ MATCHER_P(CreditCardMatches, guid, "") {
TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOff) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
@@ -129,11 +130,11 @@ TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn) {
EnableAutofillCreditCardAssist();
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
- std::vector<FormStructure*> form_structures;
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// With valid input, the function extracts the credit card form properly.
- form_structures.push_back(form_structure.get());
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
}
@@ -143,8 +144,8 @@ TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn) {
TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn_NotSecure) {
EnableAutofillCreditCardAssist();
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
- std::vector<FormStructure*> form_structures;
- form_structures.push_back(form_structure.get());
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
// Cannot be shown if the context is not secure.
autofill_client_.set_is_context_secure(false);
@@ -160,7 +161,8 @@ TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_CancelCvc) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
// Will extract the credit card form data.
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// Create a valid card for the assist.
@@ -181,7 +183,8 @@ TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_SubmitCvc) {
std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm();
// Will extract the credit card form data.
- std::vector<FormStructure*> form_structures{form_structure.get()};
+ std::vector<std::unique_ptr<FormStructure>> form_structures;
+ form_structures.push_back(std::move(form_structure));
EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures));
// Create a valid card for the assist.

Powered by Google App Engine
This is Rietveld 408576698