| OLD | NEW |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "components/autofill/core/browser/autofill_assistant.h" | 5 #include "components/autofill/core/browser/autofill_assistant.h" |
| 6 | 6 |
| 7 #include <memory> | 7 #include <memory> |
| 8 | 8 |
| 9 #include "base/callback.h" | 9 #include "base/callback.h" |
| 10 #include "base/feature_list.h" | 10 #include "base/feature_list.h" |
| (...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 112 | 112 |
| 113 MATCHER_P(CreditCardMatches, guid, "") { | 113 MATCHER_P(CreditCardMatches, guid, "") { |
| 114 return arg.guid() == guid; | 114 return arg.guid() == guid; |
| 115 } | 115 } |
| 116 | 116 |
| 117 // If the feature is turned off, CanShowCreditCardAssist() always returns | 117 // If the feature is turned off, CanShowCreditCardAssist() always returns |
| 118 // false. | 118 // false. |
| 119 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOff) { | 119 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOff) { |
| 120 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); | 120 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); |
| 121 | 121 |
| 122 std::vector<FormStructure*> form_structures{form_structure.get()}; | 122 std::vector<std::unique_ptr<FormStructure>> form_structures; |
| 123 form_structures.push_back(std::move(form_structure)); |
| 123 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 124 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 124 } | 125 } |
| 125 | 126 |
| 126 // Tests that with the feature enabled and proper input, | 127 // Tests that with the feature enabled and proper input, |
| 127 // CanShowCreditCardAssist() behaves as expected. | 128 // CanShowCreditCardAssist() behaves as expected. |
| 128 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn) { | 129 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn) { |
| 129 EnableAutofillCreditCardAssist(); | 130 EnableAutofillCreditCardAssist(); |
| 130 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); | 131 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); |
| 131 | 132 |
| 132 std::vector<FormStructure*> form_structures; | 133 std::vector<std::unique_ptr<FormStructure>> form_structures; |
| 133 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 134 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 134 | 135 |
| 135 // With valid input, the function extracts the credit card form properly. | 136 // With valid input, the function extracts the credit card form properly. |
| 136 form_structures.push_back(form_structure.get()); | 137 form_structures.push_back(std::move(form_structure)); |
| 137 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 138 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 138 } | 139 } |
| 139 | 140 |
| 140 // Tests that with the feature enabled and proper input, | 141 // Tests that with the feature enabled and proper input, |
| 141 // CanShowCreditCardAssist() behaves as expected for secure vs insecure | 142 // CanShowCreditCardAssist() behaves as expected for secure vs insecure |
| 142 // contexts. | 143 // contexts. |
| 143 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn_NotSecure) { | 144 TEST_F(AutofillAssistantTest, CanShowCreditCardAssist_FeatureOn_NotSecure) { |
| 144 EnableAutofillCreditCardAssist(); | 145 EnableAutofillCreditCardAssist(); |
| 145 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); | 146 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); |
| 146 std::vector<FormStructure*> form_structures; | 147 std::vector<std::unique_ptr<FormStructure>> form_structures; |
| 147 form_structures.push_back(form_structure.get()); | 148 form_structures.push_back(std::move(form_structure)); |
| 148 | 149 |
| 149 // Cannot be shown if the context is not secure. | 150 // Cannot be shown if the context is not secure. |
| 150 autofill_client_.set_is_context_secure(false); | 151 autofill_client_.set_is_context_secure(false); |
| 151 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 152 EXPECT_FALSE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 152 | 153 |
| 153 // Can be shown if the context is secure. | 154 // Can be shown if the context is secure. |
| 154 autofill_client_.set_is_context_secure(true); | 155 autofill_client_.set_is_context_secure(true); |
| 155 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 156 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 156 } | 157 } |
| 157 | 158 |
| 158 TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_CancelCvc) { | 159 TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_CancelCvc) { |
| 159 EnableAutofillCreditCardAssist(); | 160 EnableAutofillCreditCardAssist(); |
| 160 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); | 161 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); |
| 161 | 162 |
| 162 // Will extract the credit card form data. | 163 // Will extract the credit card form data. |
| 163 std::vector<FormStructure*> form_structures{form_structure.get()}; | 164 std::vector<std::unique_ptr<FormStructure>> form_structures; |
| 165 form_structures.push_back(std::move(form_structure)); |
| 164 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 166 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 165 | 167 |
| 166 // Create a valid card for the assist. | 168 // Create a valid card for the assist. |
| 167 CreditCard card; | 169 CreditCard card; |
| 168 test::SetCreditCardInfo(&card, "John Doe", "4111111111111111", "05", "2999"); | 170 test::SetCreditCardInfo(&card, "John Doe", "4111111111111111", "05", "2999"); |
| 169 | 171 |
| 170 // FillCreditCardForm should not be called if the user cancelled the CVC. | 172 // FillCreditCardForm should not be called if the user cancelled the CVC. |
| 171 EXPECT_CALL(autofill_manager_, FillCreditCardForm(_, _, _, _, _)).Times(0); | 173 EXPECT_CALL(autofill_manager_, FillCreditCardForm(_, _, _, _, _)).Times(0); |
| 172 | 174 |
| 173 autofill_assistant_.ShowAssistForCreditCard(card); | 175 autofill_assistant_.ShowAssistForCreditCard(card); |
| 174 static_cast<CardUnmaskDelegate*>( | 176 static_cast<CardUnmaskDelegate*>( |
| 175 autofill_manager_.GetOrCreateFullCardRequest()) | 177 autofill_manager_.GetOrCreateFullCardRequest()) |
| 176 ->OnUnmaskPromptClosed(); | 178 ->OnUnmaskPromptClosed(); |
| 177 } | 179 } |
| 178 | 180 |
| 179 TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_SubmitCvc) { | 181 TEST_F(AutofillAssistantTest, ShowAssistForCreditCard_ValidCard_SubmitCvc) { |
| 180 EnableAutofillCreditCardAssist(); | 182 EnableAutofillCreditCardAssist(); |
| 181 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); | 183 std::unique_ptr<FormStructure> form_structure = CreateValidCreditCardForm(); |
| 182 | 184 |
| 183 // Will extract the credit card form data. | 185 // Will extract the credit card form data. |
| 184 std::vector<FormStructure*> form_structures{form_structure.get()}; | 186 std::vector<std::unique_ptr<FormStructure>> form_structures; |
| 187 form_structures.push_back(std::move(form_structure)); |
| 185 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); | 188 EXPECT_TRUE(autofill_assistant_.CanShowCreditCardAssist(form_structures)); |
| 186 | 189 |
| 187 // Create a valid card for the assist. | 190 // Create a valid card for the assist. |
| 188 CreditCard card; | 191 CreditCard card; |
| 189 test::SetCreditCardInfo(&card, "John Doe", "4111111111111111", "05", "2999"); | 192 test::SetCreditCardInfo(&card, "John Doe", "4111111111111111", "05", "2999"); |
| 190 | 193 |
| 191 // FillCreditCardForm ends up being called after user has accepted the | 194 // FillCreditCardForm ends up being called after user has accepted the |
| 192 // prompt. | 195 // prompt. |
| 193 EXPECT_CALL( | 196 EXPECT_CALL( |
| 194 autofill_manager_, | 197 autofill_manager_, |
| 195 FillCreditCardForm(kNoQueryId, _, _, CreditCardMatches(card.guid()), | 198 FillCreditCardForm(kNoQueryId, _, _, CreditCardMatches(card.guid()), |
| 196 base::ASCIIToUTF16("123"))); | 199 base::ASCIIToUTF16("123"))); |
| 197 | 200 |
| 198 autofill_assistant_.ShowAssistForCreditCard(card); | 201 autofill_assistant_.ShowAssistForCreditCard(card); |
| 199 | 202 |
| 200 CardUnmaskDelegate::UnmaskResponse unmask_response; | 203 CardUnmaskDelegate::UnmaskResponse unmask_response; |
| 201 unmask_response.cvc = base::ASCIIToUTF16("123"); | 204 unmask_response.cvc = base::ASCIIToUTF16("123"); |
| 202 static_cast<CardUnmaskDelegate*>( | 205 static_cast<CardUnmaskDelegate*>( |
| 203 autofill_manager_.GetOrCreateFullCardRequest()) | 206 autofill_manager_.GetOrCreateFullCardRequest()) |
| 204 ->OnUnmaskResponse(unmask_response); | 207 ->OnUnmaskResponse(unmask_response); |
| 205 } | 208 } |
| 206 | 209 |
| 207 } // namespace autofill | 210 } // namespace autofill |
| OLD | NEW |