Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6422)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)
Patch Set: Comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 3f9f5a88871ab750d2c746cd009394b49cfe2330..ff317cb72a7d979d98d267f2e01b10ce87ea3d0b 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1593,7 +1593,7 @@ bool IsTabDetachingInFullscreenEnabled() {
- (void)dismissPermissionBubble {
PermissionRequestManager* manager = [self permissionRequestManager];
if (manager)
- manager->HideBubble();
+ manager->DismissBubble();
raymes 2016/10/27 01:47:52 Actually, can we just cast manager to a Permission
dominickn 2016/10/27 02:09:02 I asked felt this question. Since you're okay with
}
// Nil out the weak translate bubble controller reference.

Powered by Google App Engine
This is Rietveld 408576698