[Mac] Address buggy permission bubble behaviour on dismissal via ESC.

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 #include <utility>
 
@@ skipping 1575 matching lines @@
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center addObserver:self
              selector:@selector(translateBubbleWindowWillClose:)
                  name:NSWindowWillCloseNotification
                object:[translateBubbleController_ window]];
 }
 
 - (void)dismissPermissionBubble {
   PermissionRequestManager* manager = [self permissionRequestManager];
   if (manager)
-    manager->HideBubble();
+    manager->DismissBubble();

[raymes, 2016/10/27 01:47:52]

Actually, can we just cast manager to a PermissionPrompt::Delegate here and call
closing? That would avoid needing to add DismissBubble at all. IsBubbleVisible
is also public so can be called if it's needed but see my other question.

[dominickn, 2016/10/27 02:09:02]

I asked felt this question. Since you're okay with it as a permissions OWNER,
I'm going to implement it.

 }
 
 // Nil out the weak translate bubble controller reference.
 - (void)translateBubbleWindowWillClose:(NSNotification*)notification {
   DCHECK_EQ([notification object], [translateBubbleController_ window]);
 
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   [center removeObserver:self
                     name:NSWindowWillCloseNotification
                   object:[translateBubbleController_ window]];
@@ skipping 403 matching lines @@
 
 - (NSRect)savedRegularWindowFrame {
   return savedRegularWindowFrame_;
 }
 
 - (BOOL)isFullscreenTransitionInProgress {
   return enteringAppKitFullscreen_ || exitingAppKitFullscreen_;
 }
 
 @end  // @implementation BrowserWindowController(WindowType)