Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/permissions/permission_request_manager.cc

Issue 2403763003: [Mac] Address buggy permission bubble behaviour on dismissal via ESC. (Closed)
Patch Set: Comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_manager.cc
diff --git a/chrome/browser/permissions/permission_request_manager.cc b/chrome/browser/permissions/permission_request_manager.cc
index 19d67cfc7acbf04645a87a951b6d16143be8b04e..9c8f52cd11026bde398ee53549fdc526adc679fa 100644
--- a/chrome/browser/permissions/permission_request_manager.cc
+++ b/chrome/browser/permissions/permission_request_manager.cc
@@ -223,6 +223,11 @@ void PermissionRequestManager::CancelRequest(PermissionRequest* request) {
NOTREACHED(); // Callers should not cancel requests that are not pending.
}
+void PermissionRequestManager::DismissBubble() {
+ if (IsBubbleVisible())
raymes 2016/10/27 01:47:52 Do you know why this check is needed? Should we ju
dominickn 2016/10/27 02:09:02 That was the exact question I posed to felt@, whet
raymes 2016/10/27 02:26:39 Do you know whether IsBubbleVisible call is needed
+ Closing();
+}
+
void PermissionRequestManager::HideBubble() {
// Disengage from the existing view if there is one.
if (!view_)

Powered by Google App Engine
This is Rietveld 408576698