[Mac] Address buggy permission bubble behaviour on dismissal via ESC.

chrome/browser/permissions/permission_request_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_request_manager.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/metrics/user_metrics_action.h"
@@ skipping 205 matching lines @@
     if (request == it->second) {
       it->second->RequestFinished();
       duplicate_requests_.erase(it);
       return;
     }
   }
 
   NOTREACHED();  // Callers should not cancel requests that are not pending.
 }
 
+void PermissionRequestManager::DismissBubble() {
+  if (IsBubbleVisible())

[raymes, 2016/10/27 01:47:52]

Do you know why this check is needed? Should we just call Closing() directly?

[dominickn, 2016/10/27 02:09:02]

That was the exact question I posed to felt@, whether the cast and call
Closing() was a better idea.

[raymes, 2016/10/27 02:26:39]

Do you know whether IsBubbleVisible call is needed? Was there a reason that you
added it?

+    Closing();
+}
+
 void PermissionRequestManager::HideBubble() {
   // Disengage from the existing view if there is one.
   if (!view_)
     return;
 
   view_->SetDelegate(nullptr);
   view_->Hide();
   view_.reset();
 }
 
@@ skipping 278 matching lines @@
     case DENY_ALL:
       Deny();
       break;
     case DISMISS:
       Closing();
       break;
     case NONE:
       NOTREACHED();
   }
 }