Issue 2403743003: Changes to testing Peer classes in preparation for Mentat integration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2403743003: Changes to testing Peer classes in preparation for Mentat integration (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Changes to testing Peer classes in preparation for Mentat integration This CL moves QuicTimeWaitListManagerPeer into its own library and adds some methods to it, and adds a method to QuicCryptoServerConfigPeer. Both of these changes will be used in an upcoming CL which completes Mentat integration and adds a bunch of dispatcher tests. relnote: n/a test changes only Merge internal change: 135177586 BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -18 lines)			Patch
M	net/net.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_crypto_server_config_peer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_crypto_server_config_peer.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	net/quic/test_tools/quic_time_wait_list_manager_peer.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	net/quic/test_tools/quic_time_wait_list_manager_peer.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager_test.cc	View	2 chunks	+1 line, -18 lines	0 comments	Download

Depends on Patchset:

Issue 2404003002 Patch 1

Dependent Patchsets:

Issue 2403233003 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages