Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2403233003: Automated rollback of internal change 130388085. (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Automated rollback of internal change 130388085. relnote: Rollback flag quic_enforce_mtu_limit. Never enabled. *** Original change description *** Original relnote: Use a small QUIC MTU when a potentially fragmented packet is received. Guarded by quic_enforce_mtu_limit. If QuicRxRing is enabled, the UDP listener will only receive "strange" packets (fragmented, IPv6 extension headers, etc.). If a connection is created from a packet on the UDP listener, shrink the connection's MTU to 1214 for its lifetime. *** Merge internal change: 135261089 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -175 lines) Patch
M net/quic/core/quic_connection.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/core/quic_protocol.h View 4 chunks +0 lines, -7 lines 0 comments Download
M net/quic/core/quic_protocol.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 9 chunks +77 lines, -105 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_packet_reader.h View 3 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (5 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-10 23:36:15 UTC) #2
Ryan Hamilton
4 years, 2 months ago (2016-10-11 02:34:16 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698