Reduce size of monomorphic checked entry.

Reduce size of monomorphic checked entry.

Flutter gallery
VMIsolate(CodeSize): 112293
Isolate(CodeSize): 2065968
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5625616
Total(CodeSize): 9525213
->
VMIsolate(CodeSize): 112292
Isolate(CodeSize): 2065966
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5592336 -0.35%
Total(CodeSize): 9491930 -0.59%

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/12b18466bb163e5f0f67e4ccaab2bf60bd442c16

[rmacnak, 2016-10-07 23:18:01]

Description was changed from

==========
Reduce size of monomorphic checked entry.
==========

to

==========
Reduce size of monomorphic checked entry.

Flutter gallery
VMIsolate(CodeSize): 112293
Isolate(CodeSize): 2065968
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5625616
Total(CodeSize): 9525213
->
VMIsolate(CodeSize): 112292
Isolate(CodeSize): 2065966
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5592336 -0.35%
Total(CodeSize): 9491930 -0.59%
==========

[rmacnak, 2016-10-10 20:57:51]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-10-10 21:10:39]

lgtm

https://codereview.chromium.org/2403613002/diff/20001/runtime/vm/assembler_x6...
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/2403613002/diff/20001/runtime/vm/assembler_x6...
runtime/vm/assembler_x64.cc:3355: nop();
Why is this nop needed?

[rmacnak, 2016-10-11 20:31:04]

https://codereview.chromium.org/2403613002/diff/20001/runtime/vm/assembler_x6...
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/2403613002/diff/20001/runtime/vm/assembler_x6...
runtime/vm/assembler_x64.cc:3355: nop();
On 2016/10/10 21:10:39, Florian Schneider wrote:
> Why is this nop needed?

IC calls in AOT store the entry as a Smi.

[rmacnak, 2016-10-11 20:58:54]

Description was changed from

==========
Reduce size of monomorphic checked entry.

Flutter gallery
VMIsolate(CodeSize): 112293
Isolate(CodeSize): 2065968
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5625616
Total(CodeSize): 9525213
->
VMIsolate(CodeSize): 112292
Isolate(CodeSize): 2065966
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5592336 -0.35%
Total(CodeSize): 9491930 -0.59%
==========

to

==========
Reduce size of monomorphic checked entry.

Flutter gallery
VMIsolate(CodeSize): 112293
Isolate(CodeSize): 2065968
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5625616
Total(CodeSize): 9525213
->
VMIsolate(CodeSize): 112292
Isolate(CodeSize): 2065966
ReadOnlyData(CodeSize): 1721336
Instructions(CodeSize): 5592336 -0.35%
Total(CodeSize): 9491930 -0.59%

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/12b18466bb163e5f0f67e4ccaab2bf60bd442c16
==========

[rmacnak, 2016-10-11 20:58:55]

Committed patchset #2 (id:20001) manually as
12b18466bb163e5f0f67e4ccaab2bf60bd442c16 (presubmit successful).