Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/build/scripts/scripts.gni

Issue 2403583002: More changes to support hermetic Xcode toolchain in GN. (Closed)
Patch Set: Comments from thakis. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/scripts.gni
diff --git a/third_party/WebKit/Source/build/scripts/scripts.gni b/third_party/WebKit/Source/build/scripts/scripts.gni
index d1c1291987f42d0465ef6ef072b191f53e31be7a..e830cdde3e299af8912bd3750199ccaa060743b5 100644
--- a/third_party/WebKit/Source/build/scripts/scripts.gni
+++ b/third_party/WebKit/Source/build/scripts/scripts.gni
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/toolchain/toolchain.gni")
import("//third_party/WebKit/Source/config.gni")
# All paths in this file should be absolute so targets in any directory can use
@@ -109,6 +110,12 @@ template("process_in_files") {
"--output_dir",
rebase_path(output_dir, root_build_dir),
]
+ if (!use_system_xcode) {
Nico 2016/10/10 19:35:59 is_mac check?
erikchen 2016/10/10 22:54:57 Done.
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
if (defined(invoker.other_args)) {
args += invoker.other_args
}

Powered by Google App Engine
This is Rietveld 408576698