Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/build/scripts/scripts.gni

Issue 2403583002: More changes to support hermetic Xcode toolchain in GN. (Closed)
Patch Set: Comments from thakis. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/toolchain/toolchain.gni")
5 import("//third_party/WebKit/Source/config.gni") 6 import("//third_party/WebKit/Source/config.gni")
6 7
7 # All paths in this file should be absolute so targets in any directory can use 8 # All paths in this file should be absolute so targets in any directory can use
8 # them without worrying about the current directory. 9 # them without worrying about the current directory.
9 _scripts_dir = "//third_party/WebKit/Source/build/scripts" 10 _scripts_dir = "//third_party/WebKit/Source/build/scripts"
10 11
11 scripts_for_in_files = [ 12 scripts_for_in_files = [
12 # jinja2/__init__.py contains version string, so sufficient as 13 # jinja2/__init__.py contains version string, so sufficient as
13 # dependency for whole jinja2 package 14 # dependency for whole jinja2 package
14 "//third_party/jinja2/__init__.py", 15 "//third_party/jinja2/__init__.py",
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 } 103 }
103 outputs = invoker.outputs 104 outputs = invoker.outputs
104 105
105 # Extract the directory to write files to. 106 # Extract the directory to write files to.
106 output_dir = get_path_info(outputs[0], "dir") 107 output_dir = get_path_info(outputs[0], "dir")
107 108
108 args = rebase_path(invoker.in_files, root_build_dir) + [ 109 args = rebase_path(invoker.in_files, root_build_dir) + [
109 "--output_dir", 110 "--output_dir",
110 rebase_path(output_dir, root_build_dir), 111 rebase_path(output_dir, root_build_dir),
111 ] 112 ]
113 if (!use_system_xcode) {
Nico 2016/10/10 19:35:59 is_mac check?
erikchen 2016/10/10 22:54:57 Done.
114 args += [
115 "--developer_dir",
116 hermetic_xcode_path,
117 ]
118 }
112 if (defined(invoker.other_args)) { 119 if (defined(invoker.other_args)) {
113 args += invoker.other_args 120 args += invoker.other_args
114 } 121 }
115 122
116 if (defined(invoker.deps)) { 123 if (defined(invoker.deps)) {
117 deps = invoker.deps 124 deps = invoker.deps
118 } else { 125 } else {
119 deps = make_core_generated_deps 126 deps = make_core_generated_deps
120 } 127 }
121 forward_variables_from(invoker, [ "visibility" ]) 128 forward_variables_from(invoker, [ "visibility" ])
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 other_inputs = make_event_factory_files 194 other_inputs = make_event_factory_files
188 forward_variables_from(invoker, 195 forward_variables_from(invoker,
189 [ 196 [
190 "deps", 197 "deps",
191 "in_files", 198 "in_files",
192 "outputs", 199 "outputs",
193 "visibility", 200 "visibility",
194 ]) 201 ])
195 } 202 }
196 } 203 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698