More changes to support hermetic Xcode toolchain in GN.

third_party/WebKit/Source/core/BUILD.gn

Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 82874c1759b6027fdd9349d9f664ce7321778f2b..c7ca326b71248ff0618a04b8ed88b189595ddb6a 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -719,6 +719,12 @@ action("make_core_generated_css_tokenizer_codepoints") {
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
@@ -742,6 +748,12 @@ action("make_core_generated_css_primitive_value_unit_trie") {
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {

[Nico, 2016/10/08 19:03:37]

do you need to check of is_mac (or (is_mac || is_ios)) too? This runs on all
platforms, right?

[erikchen, 2016/10/10 19:20:57]

It's not strictly necessary, but I think it makes more sense to include the
conditional for is_mac.

+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
@@ -767,6 +779,12 @@ action("make_core_generated_html_element_lookup_trie") {
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
@@ -790,6 +808,12 @@ action("make_core_generated_origin_trials") {
     "--output_dir",
     "$rel_blink_core_gen_dir/origin_trials",
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 }
 
 action_foreach("make_core_generated_bison") {