More changes to support hermetic Xcode toolchain in GN.

third_party/WebKit/Source/core/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/toolchain/toolchain.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 import("//third_party/WebKit/Source/bindings/bindings.gni")
@@ skipping 701 matching lines @@
   script = "../build/scripts/make_css_tokenizer_codepoints.py"
 
   outputs = [
     "$blink_core_output_dir/CSSTokenizerCodepoints.cpp",
   ]
 
   args = [
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
 
 action("make_core_generated_css_primitive_value_unit_trie") {
   visibility = []  # Allow re-assignment of list.
   visibility = [ ":*" ]
   script = "../build/scripts/make_css_primitive_value_unit_trie.py"
 
   input_file = "css/CSSPrimitiveValueUnits.in"
   inputs = make_trie_helpers_files + [
              input_file,
              "../build/scripts/templates/CSSPrimitiveValueUnitTrie.cpp.tmpl",
            ]
   outputs = [
     "$blink_core_output_dir/CSSPrimitiveValueUnitTrie.cpp",
   ]
 
   args = [
     rebase_path(input_file, root_build_dir),
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {

[Nico, 2016/10/08 19:03:37]

do you need to check of is_mac (or (is_mac || is_ios)) too? This runs on all
platforms, right?

[erikchen, 2016/10/10 19:20:57]

It's not strictly necessary, but I think it makes more sense to include the
conditional for is_mac.

+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
 
 action("make_core_generated_html_element_lookup_trie") {
   visibility = []  # Allow re-assignment of list.
   visibility = [ ":*" ]
   script = "../build/scripts/make_element_lookup_trie.py"
 
   input_file = "html/HTMLTagNames.in"
   inputs = make_trie_helpers_files + [
              input_file,
              "../build/scripts/templates/ElementLookupTrie.cpp.tmpl",
              "../build/scripts/templates/ElementLookupTrie.h.tmpl",
            ]
   outputs = [
     "$blink_core_output_dir/HTMLElementLookupTrie.cpp",
     "$blink_core_output_dir/HTMLElementLookupTrie.h",
   ]
 
   args = [
     rebase_path(input_file, root_build_dir),
     "--output_dir",
     rel_blink_core_gen_dir,
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 
   deps = make_core_generated_deps
 }
 
 action("make_core_generated_origin_trials") {
   script = "../build/scripts/make_origin_trials.py"
 
   inputs = scripts_for_in_files + [
              "../build/scripts/make_origin_trials.py",
              "../platform/RuntimeEnabledFeatures.in",
              "../build/scripts/templates/OriginTrials.cpp.tmpl",
              "../build/scripts/templates/OriginTrials.h.tmpl",
            ]
   outputs = [
     "$blink_core_output_dir/origin_trials/OriginTrials.cpp",
     "$blink_core_output_dir/origin_trials/OriginTrials.h",
   ]
 
   args = [
     rebase_path("../platform/RuntimeEnabledFeatures.in", root_build_dir),
     "--output_dir",
     "$rel_blink_core_gen_dir/origin_trials",
   ]
+  if (!use_system_xcode) {
+    args += [
+      "--developer_dir",
+      hermetic_xcode_path,
+    ]
+  }
 }
 
 action_foreach("make_core_generated_bison") {
   script = "../build/scripts/rule_bison.py"
   sources = [
     "xml/XPathGrammar.y",
   ]
   outputs = [
     "$blink_core_output_dir/{{source_name_part}}.cpp",
     "$blink_core_output_dir/{{source_name_part}}.h",
@@ skipping 456 matching lines @@
   sources = [
     "html/parser/HTMLPreloadScannerFuzzer.cpp",
     "html/parser/TextResourceDecoderForFuzzing.h",
   ]
   seed_corpus = "//third_party/WebKit/LayoutTests/fast/parser"
   deps = [
     ":core",
     "../platform:blink_fuzzer_test_support",
   ]
 }