Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7470)

Unified Diff: chrome/browser/resources/feedback/html/sys_info.html

Issue 2403503003: Optimize the table creation in the Sys Info page of the feedback app (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback/html/sys_info.html
diff --git a/chrome/browser/resources/feedback/html/sys_info.html b/chrome/browser/resources/feedback/html/sys_info.html
index 30fd6a5a767823e2012c7926c7b2fac2aa90de83..dc17eca9057c2e2524501cea16ea838ac55a32db 100644
--- a/chrome/browser/resources/feedback/html/sys_info.html
+++ b/chrome/browser/resources/feedback/html/sys_info.html
@@ -4,13 +4,15 @@
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<title i18n-content="sysinfoPageTitle"></title>
<link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
+ <link rel="stylesheet" href="chrome://resources/css/spinner.css">
<link rel="stylesheet" href="../../about_sys/about_sys.css">
<script src="chrome://resources/js/util.js"></script>
<script src="chrome://resources/js/i18n_template_no_process.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
<script src="../js/sys_info.js"></script>
<style>
- html, body {
+ html,
+ body {
overflow: visible;
}
</style>
@@ -23,10 +25,16 @@
<div id="content">
<h2 id="tableTitle" i18n-content="sysinfoPageTableTitle"></h2>
<div id="anchor"></div>
- <button id="expandAllBtn" class="global-button" i18n-content="sysinfoPageExpandAllBtn"></button>
- <button id="collapseAllBtn" class="global-button" i18n-content="sysinfoPageCollapseAllBtn"></button>
- <p id="status" i18n-content="sysinfoPageStatusLoading"></p>
- <table class="list" id="detailsTable"></table>
+ <button id="expandAllBtn" class="global-button"
+ i18n-content="sysinfoPageExpandAllBtn"></button>
+ <button id="collapseAllBtn" class="global-button"
+ i18n-content="sysinfoPageCollapseAllBtn"></button>
+ <div id="spinner-container">
+ <div class="inline-spinner"></div>
+ <p id="status" i18n-content="sysinfoPageStatusLoading"
+ style="display: inline-block;"></p>
xiyuan 2016/10/10 16:57:35 Move the style to css.
afakhry 2016/10/12 16:12:07 Done. Moved all the styles here specific to sysinf
xiyuan 2016/10/12 16:26:03 Cool. Thanks.
+ </div>
+ <table class="list" id="detailsTable" style="margin-top: .5em"></table>
</div>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698