chrome/browser/resources/feedback/html/sys_info.html - Issue 2403503003: Optimize the table creation in the Sys Info page of the feedback app

Side by Side Diff: chrome/browser/resources/feedback/html/sys_info.html

Issue 2403503003: Optimize the table creation in the Sys Info page of the feedback app (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/browser/resources/about_sys/about_sys.css ('k') | chrome/browser/resources/feedback/js/feedback.js » ('j') | chrome/browser/resources/feedback/js/sys_info.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">	4 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

5 <title i18n-content="sysinfoPageTitle"></title>	5 <title i18n-content="sysinfoPageTitle"></title>

6 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	6 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

	7 <link rel="stylesheet" href="chrome://resources/css/spinner.css">

7 <link rel="stylesheet" href="../../about_sys/about_sys.css">	8 <link rel="stylesheet" href="../../about_sys/about_sys.css">

8 <script src="chrome://resources/js/util.js"></script>	9 <script src="chrome://resources/js/util.js"></script>

9 <script src="chrome://resources/js/i18n_template_no_process.js"></script>	10 <script src="chrome://resources/js/i18n_template_no_process.js"></script>

10 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	11 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

11 <script src="../js/sys_info.js"></script>	12 <script src="../js/sys_info.js"></script>

12 <style>	13 <style>

13 html, body {	14 html,

	15 body {

14 overflow: visible;	16 overflow: visible;

15 }	17 }

16 </style>	18 </style>

17 </head>	19 </head>

18 <body>	20 <body>

19 <div id="header">	21 <div id="header">

20 <h1 id="title" i18n-content="sysinfoPageTitle"></h1>	22 <h1 id="title" i18n-content="sysinfoPageTitle"></h1>

21 <p id="description" i18n-content="sysinfoPageDescription"></p>	23 <p id="description" i18n-content="sysinfoPageDescription"></p>

22 </div>	24 </div>

23 <div id="content">	25 <div id="content">

24 <h2 id="tableTitle" i18n-content="sysinfoPageTableTitle"></h2>	26 <h2 id="tableTitle" i18n-content="sysinfoPageTableTitle"></h2>

25 <div id="anchor"></div>	27 <div id="anchor"></div>

26 <button id="expandAllBtn" class="global-button" i18n-content="sysinfoPageE xpandAllBtn"></button>	28 <button id="expandAllBtn" class="global-button"

27 <button id="collapseAllBtn" class="global-button" i18n-content="sysinfoPag eCollapseAllBtn"></button>	29 i18n-content="sysinfoPageExpandAllBtn"></button>

28 <p id="status" i18n-content="sysinfoPageStatusLoading"></p>	30 <button id="collapseAllBtn" class="global-button"

29 <table class="list" id="detailsTable"></table>	31 i18n-content="sysinfoPageCollapseAllBtn"></button>

	32 <div id="spinner-container">

	33 <div class="inline-spinner"></div>

	34 <p id="status" i18n-content="sysinfoPageStatusLoading"

	35 style="display: inline-block;"></p>
	xiyuan 2016/10/10 16:57:35 Move the style to css. Move the style to css. afakhry 2016/10/12 16:12:07 Done. Moved all the styles here specific to sysinf Show quoted text On 2016/10/10 16:57:35, xiyuan wrote: > Move the style to css. Done. Moved all the styles here specific to sysinfo (not about_sys) to a separate css file. xiyuan 2016/10/12 16:26:03 Cool. Thanks. Show quoted text On 2016/10/12 16:12:07, afakhry wrote: > On 2016/10/10 16:57:35, xiyuan wrote: > > Move the style to css. > > Done. Moved all the styles here specific to sysinfo (not about_sys) to a > separate css file. Cool. Thanks.
	36 </div>

	37 <table class="list" id="detailsTable" style="margin-top: .5em"></table>

30 </div>	38 </div>

31 </body>	39 </body>

32 </html>	40 </html>

OLD	NEW