Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2403493002: [inspector] don't use String16 in inspector test runner (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] don't use String16 in inspector test runner String16 is not public part of src/inspector. All usage are replaced with vector of char/unit16_t to avoid potential linker problems. BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Committed: https://crrev.com/2d5cc49b72dd2ca09b8a2714fbcb412a07b42408 Cr-Commit-Position: refs/heads/master@{#40098}

Patch Set 1 #

Patch Set 2 : enable inspector to run try bots #

Patch Set 3 : a #

Patch Set 4 : a #

Patch Set 5 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -47 lines) Patch
M test/inspector/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M test/inspector/inspector.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/inspector/inspector-impl.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M test/inspector/inspector-test.cc View 4 chunks +37 lines, -20 lines 0 comments Download
M test/inspector/task-runner.h View 2 chunks +6 lines, -3 lines 0 comments Download
M test/inspector/task-runner.cc View 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
kozy
Dmitry, please take a look.
4 years, 2 months ago (2016-10-07 18:16:05 UTC) #7
dgozman
lgtm modulo build changes - don't forget to revert them
4 years, 2 months ago (2016-10-07 19:18:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403493002/80001
4 years, 2 months ago (2016-10-07 20:50:00 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-07 21:16:47 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:17:04 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2d5cc49b72dd2ca09b8a2714fbcb412a07b42408
Cr-Commit-Position: refs/heads/master@{#40098}

Powered by Google App Engine
This is Rietveld 408576698