Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: test/inspector/task-runner.h

Issue 2403493002: [inspector] don't use String16 in inspector test runner (Closed)
Patch Set: a Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | test/inspector/task-runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/task-runner.h
diff --git a/test/inspector/task-runner.h b/test/inspector/task-runner.h
index 88c36543d3785b61c82dd7b808eb353b37c53a9a..fc65ab7cdef3f96f8417bf9a70b077dd5c788659 100644
--- a/test/inspector/task-runner.h
+++ b/test/inspector/task-runner.h
@@ -10,8 +10,8 @@
#include "include/v8.h"
#include "src/base/macros.h"
#include "src/base/platform/platform.h"
-#include "src/inspector/string-16.h"
#include "src/locked-queue-inl.h"
+#include "src/vector.h"
class TaskRunner : public v8::base::Thread {
public:
@@ -65,14 +65,17 @@ class TaskRunner : public v8::base::Thread {
class ExecuteStringTask : public TaskRunner::Task {
public:
- explicit ExecuteStringTask(const v8_inspector::String16& expression);
+ explicit ExecuteStringTask(const v8::internal::Vector<uint16_t>& expression);
+ explicit ExecuteStringTask(
+ const v8::internal::Vector<const char>& expression);
bool is_inspector_task() override { return false; }
void Run(v8::Isolate* isolate,
const v8::Global<v8::Context>& context) override;
private:
- v8_inspector::String16 expression_;
+ v8::internal::Vector<uint16_t> expression_;
+ v8::internal::Vector<const char> expression_utf8_;
DISALLOW_COPY_AND_ASSIGN(ExecuteStringTask);
};
« no previous file with comments | « test/inspector/inspector-test.cc ('k') | test/inspector/task-runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698