chromeos: Update IdleActionImminent and SuspendDone handling

chromeos: Update IdleActionImminent and SuspendDone handling

IdleActionImminent signals sent by powerd now include the
remaining time until the idle action will be performed; make
PowerManagerClient decode it and pass it to observers.

Also update PowerManagerClient to listen for SuspendDone
signals rather than SuspendStateChanged; the latter is
confusing and will be removed soon.

Updates the system_api dependency to a9acc4df.

BUG=287787, 359619
TBR=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265058

[Daniel Erat, 2014-04-16 20:28:53]

TBR stevenjb@ for rename in chromeos/network

[stevenjb, 2014-04-16 21:42:29]

chromeos/network lgtm

[Daniel Erat, 2014-04-18 13:17:07]

Bartosz: ping

[Daniel Erat, 2014-04-21 13:49:57]

On 2014/04/18 13:17:07, Daniel Erat wrote:
> Bartosz: ping

Steven, do you mind doing a full review? The actual changes are pretty minimal
(updating PowerManagerClient to use SuspendDone rather than SuspendStateChanged,
and to decode a protobuf that's now included in IdleActionImminent signals and
pass it to observers).

[stevenjb, 2014-04-21 16:47:32]

lgtm

[Daniel Erat, 2014-04-21 17:29:03]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-04-21 17:29:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/240343004/70001

[commit-bot: I haz the power, 2014-04-21 20:48:02]

Change committed as 265058

[bartfab (slow), 2014-04-23 11:49:30]

LGTM. Sorry for the delay - it was a 4-day weekend here.

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/fake_power...
File chromeos/dbus/fake_power_manager_client.h (right):

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/fake_power...
chromeos/dbus/fake_power_manager_client.h:12: #include "base/time/time.h"
Nit: No longer used.

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.cc:506: proto.time_until_idle_action())));
Nit: This line should be indented four spaces from the start of the previous
line, not from the start of base::TimeDelta.

[Daniel Erat, 2014-04-23 14:35:33]

uploaded https://codereview.chromium.org/249413002 to fix the nits

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/fake_power...
File chromeos/dbus/fake_power_manager_client.h (right):

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/fake_power...
chromeos/dbus/fake_power_manager_client.h:12: #include "base/time/time.h"
On 2014/04/23 11:49:30, bartfab wrote:
> Nit: No longer used.

Done.

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.cc:506: proto.time_until_idle_action())));
On 2014/04/23 11:49:30, bartfab wrote:
> Nit: This line should be indented four spaces from the start of the previous
> line, not from the start of base::TimeDelta.

debatable unless the style guide has been updated or the chromium codebase has
suddenly become way more consistent than it used to be, but done in any case.
:-P

[bartfab (slow), 2014-04-23 14:50:22]

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
File chromeos/dbus/power_manager_client.cc (right):

https://codereview.chromium.org/240343004/diff/70001/chromeos/dbus/power_mana...
chromeos/dbus/power_manager_client.cc:506: proto.time_until_idle_action())));
On 2014/04/23 14:35:34, Daniel Erat wrote:
> On 2014/04/23 11:49:30, bartfab wrote:
> > Nit: This line should be indented four spaces from the start of the previous
> > line, not from the start of base::TimeDelta.
> 
> debatable unless the style guide has been updated or the chromium codebase has
> suddenly become way more consistent than it used to be, but done in any case.
> :-P

Neither of these is very likely. I guess I just like to pretend things are more
consistent than they really are :).