Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 249413002: chromeos: Clean up PowerManagerClient nits from r265058. (Closed)

Created:
6 years, 8 months ago by Daniel Erat
Modified:
6 years, 8 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

chromeos: Clean up PowerManagerClient nits from r265058. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chromeos/dbus/fake_power_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_power_manager_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Erat
6 years, 8 months ago (2014-04-23 14:35:46 UTC) #1
bartfab (slow)
lgtm
6 years, 8 months ago (2014-04-23 14:50:55 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 8 months ago (2014-04-23 14:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/249413002/1
6 years, 8 months ago (2014-04-23 14:51:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 15:09:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-23 15:09:00 UTC) #6
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 8 months ago (2014-04-23 15:12:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/249413002/1
6 years, 8 months ago (2014-04-23 15:12:29 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 17:34:20 UTC) #9
Message was sent while issue was closed. 
Change committed as 265675

Powered by Google App Engine
This is Rietveld 408576698