Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2403373002: cc: Clean up OutputSurfaceClient. (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 2 months ago
CC:
anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jessicag+watch-blimp_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kylechar, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, piman+watch_chromium.org, rjkroege, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sievers+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up OutputSurfaceClient. Renames DidSwapBuffersComplete to DidReceiveSwapBuffersAck which mirrors the naming used for CompositorFrameSink but for swap. Removes methods that are only for the layer compositor and not part of the actual OutputSurface interaction. R=boliu@chromium.org, enne@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/440bc6802b846f245be07be883281e8fb0840854 Cr-Commit-Position: refs/heads/master@{#425442}

Patch Set 1 #

Patch Set 2 : osclient: . #

Patch Set 3 : osclient: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -141 lines) Patch
M blimp/client/support/compositor/blimp_embedder_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.h View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/output/output_surface_client.h View 1 chunk +10 lines, -39 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display.h View 1 2 1 chunk +1 line, -11 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 chunks +3 lines, -34 lines 0 comments Download
M cc/surfaces/display_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_output_surface.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/fake_output_surface_client.h View 3 chunks +4 lines, -21 lines 0 comments Download
M cc/test/fake_output_surface_client.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M cc/test/pixel_test_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M services/ui/surfaces/direct_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (17 generated)
danakj
enne: overall boliu: c/b/ khushal: blimp/ fsamuel: services/
4 years, 2 months ago (2016-10-11 01:18:23 UTC) #7
boliu
lgtm
4 years, 2 months ago (2016-10-11 15:05:33 UTC) #10
Fady Samuel
lgtm
4 years, 2 months ago (2016-10-11 15:06:22 UTC) #11
Khushal
lgtm
4 years, 2 months ago (2016-10-11 17:14:15 UTC) #13
enne (OOO)
lgtm
4 years, 2 months ago (2016-10-11 17:27:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403373002/40001
4 years, 2 months ago (2016-10-14 19:49:09 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-14 19:57:10 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:59:36 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/440bc6802b846f245be07be883281e8fb0840854
Cr-Commit-Position: refs/heads/master@{#425442}

Powered by Google App Engine
This is Rietveld 408576698